From owner-svn-src-all@FreeBSD.ORG Thu Jan 17 03:41:23 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 9079D32E for ; Thu, 17 Jan 2013 03:41:23 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-la0-f44.google.com (mail-la0-f44.google.com [209.85.215.44]) by mx1.freebsd.org (Postfix) with ESMTP id 02FA6799 for ; Thu, 17 Jan 2013 03:41:22 +0000 (UTC) Received: by mail-la0-f44.google.com with SMTP id eb20so1018401lab.31 for ; Wed, 16 Jan 2013 19:41:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=teeKrHj9lJDjzm17y09JVV6TCs9lMPkl+GjnDlFmRAo=; b=No3hWx1G/aG4/ygIunsEJYWmv2QF/pG4tD4buqH/tlXQe7PG1QBBG203rOENc0+Mr7 M1Amt2czeKr8DT9vjAMAh9HJW6pHTgE1I/NAhXLH51pjPBTdwOZvVbw9Mp0yXnyRf9bc je9IDV8Q9A+hqg+tj4BG4WD6vUIRMOBXqrJL0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=teeKrHj9lJDjzm17y09JVV6TCs9lMPkl+GjnDlFmRAo=; b=l7oBsBdMav2hYEvXbjT0QTb/QtxBw3kMceUKKYDJzskY6hxnLcVdkXhz4IigH6r6Y1 gjhK3+5yrHBspGXZQWgxl0vXg/RSZ9l3nc6cYyFDJMFsSyXDNREdUuqfBGp6ZD5i2APA xVZhFV4Rpk77UjRx/eE1g2S3E7wlAIrhU0iHDrCMEJOHUCHP33BCIx6wgQ++zKPEyE9I pn/1riG1n3NLh+1dFb3GmQMfL5qLivNVbcQpgMSUkPfjY0R19KaaBdHwgBaEk5IZboP9 ck0SzZY0r3GjB4W89JjH6hGRBA1rZVdy0LFSrEZ92Wl5goCP/QTKI0v2fxBbstmurnaQ Y7Aw== X-Received: by 10.152.125.136 with SMTP id mq8mr3286904lab.41.1358394081599; Wed, 16 Jan 2013 19:41:21 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.30.131 with HTTP; Wed, 16 Jan 2013 19:40:51 -0800 (PST) In-Reply-To: <20130117130740.I1066@besplex.bde.org> References: <201301161815.r0GIFQPk007553@svn.freebsd.org> <20130117130740.I1066@besplex.bde.org> From: Eitan Adler Date: Wed, 16 Jan 2013 22:40:51 -0500 X-Google-Sender-Auth: MvjbaOfpgIqbw6yjJMROFwC1Rfs Message-ID: Subject: Re: svn commit: r245506 - head/bin/pwait To: Bruce Evans Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQmsze5+PJd2YFLs28HhygPSC/wYtvp1jrBLla5qolmbzFLSq6LVDfHzvO9KFyYNfB7LbSAc Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Xin LI X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2013 03:41:23 -0000 On 16 January 2013 21:25, Bruce Evans wrote: > This uses the sysexits mistake. style(9) was fixed to not give an example > of this mistake. Before this, sysexits was used a whole once in pwait(1) > (for EX_USAGE) in usage(). EX_USAGE happens to be 64. As usual when the > mistake is used, this is useless for humans (the usage message gives more > info) and unusable for programs, especially since it is undocmented > (pwait(1)'s man page just says ">0 if an error occurs". It doesn't even > use '.Std' for this, but hard-codes it. IMHO using sysexits gives more signal than using a binary 0 or 1. It is a mistake to have changed style(9) to avoid using sysexits. Instead the man page should detail the specific error that occurs directly, or by reference to sysexit. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams