From owner-freebsd-bugs@FreeBSD.ORG Thu Jan 13 18:30:11 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 044FC1065696 for ; Thu, 13 Jan 2011 18:30:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id B5E9E8FC17 for ; Thu, 13 Jan 2011 18:30:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p0DIUAAZ035766 for ; Thu, 13 Jan 2011 18:30:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p0DIUAuG035763; Thu, 13 Jan 2011 18:30:10 GMT (envelope-from gnats) Resent-Date: Thu, 13 Jan 2011 18:30:10 GMT Resent-Message-Id: <201101131830.p0DIUAuG035763@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Pedro F. Giffuni" Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CCA5910656A5 for ; Thu, 13 Jan 2011 18:21:42 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id BC1358FC1E for ; Thu, 13 Jan 2011 18:21:42 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p0DILgxr066232 for ; Thu, 13 Jan 2011 18:21:42 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p0DILg3P066231; Thu, 13 Jan 2011 18:21:42 GMT (envelope-from nobody) Message-Id: <201101131821.p0DILg3P066231@red.freebsd.org> Date: Thu, 13 Jan 2011 18:21:42 GMT From: "Pedro F. Giffuni" To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: gnu/153959: Minor mips-specific gcc update X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Jan 2011 18:30:11 -0000 >Number: 153959 >Category: gnu >Synopsis: Minor mips-specific gcc update >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Thu Jan 13 18:30:10 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Pedro F. Giffuni >Release: 8.2-RC1 >Organization: >Environment: Non-relevant ... this only applies to MIPS platform. >Description: While I was looking for some GPLv2 updates for GCC (submitted as gnu/153298), I noticed this MIPS specific change that was committed upstream before the GPLv3 switch: ______ 2007-08-20 Adam Nemet * config/mips/predicates.md (const_call_insn_operand): Invoke SYMBOL_REF_LONG_CALL_P only on SYMBOL_REFs. http://gcc.gnu.org/viewcvs/branches/gcc-4_2-branch/gcc/config/mips/predicates.md?r1=117923&r2=127658&pathrev=127959 ______ I have no idea of the relevance of the issue and I don't have a MIPS platform to try this so I didn't include it in the patchset, but it is to be the expected behavior in upstream gcc, so I believe it should be committed. >How-To-Repeat: >Fix: The following patch applies cleanly to base gcc. Patch attached with submission follows: --- gcc/config/mips/predicates.md 2006/10/21 02:41:38 117923 +++ gcc/config/mips/predicates.md 2007/08/21 00:50:59 127658 @@ -116,7 +116,9 @@ /* If -mlong-calls, force all calls to use register addressing. Also, if this function has the long_call attribute, we must use register addressing. */ - return !TARGET_LONG_CALLS && !SYMBOL_REF_LONG_CALL_P (op); + return (!TARGET_LONG_CALLS + && !(GET_CODE (op) == SYMBOL_REF + && SYMBOL_REF_LONG_CALL_P (op))); case SYMBOL_GOT_GLOBAL: /* Without explicit relocs, there is no special syntax for >Release-Note: >Audit-Trail: >Unformatted: