From owner-cvs-src@FreeBSD.ORG Tue Feb 3 09:04:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 2FA4316A4CF for ; Tue, 3 Feb 2004 09:04:21 -0800 (PST) Received: from mailtoaster1.pipeline.ch (mailtoaster1.pipeline.ch [62.48.0.70]) by mx1.FreeBSD.org (Postfix) with ESMTP id B0F9443D46 for ; Tue, 3 Feb 2004 09:03:27 -0800 (PST) (envelope-from andre@freebsd.org) Received: (qmail 76436 invoked from network); 3 Feb 2004 17:02:56 -0000 Received: from unknown (HELO freebsd.org) ([62.48.0.53]) (envelope-sender ) by mailtoaster1.pipeline.ch (qmail-ldap-1.03) with SMTP for ; 3 Feb 2004 17:02:56 -0000 Message-ID: <401FD43E.174A6839@freebsd.org> Date: Tue, 03 Feb 2004 18:02:54 +0100 From: Andre Oppermann X-Mailer: Mozilla 4.76 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: Ken Smith , Tom Rhodes , Ruslan Ermilov , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200402030932.i139WBpQ054113@repoman.freebsd.org> <20040203112824.01dfdc99@localhost> <20040203163214.GD17960@electra.cse.Buffalo.EDU> <401FD252.7F56765E@freebsd.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: Re: cvs commit: src/kerberos5/lib/libroken Makefile X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Feb 2004 17:04:21 -0000 Andre Oppermann wrote: > > Ken Smith wrote: > > > > On Tue, Feb 03, 2004 at 11:28:24AM -0500, Tom Rhodes wrote: > > > On Tue, 3 Feb 2004 01:32:11 -0800 (PST) > > > Ruslan Ermilov wrote: > > > > > > > bland 2004/02/03 01:32:11 PST > > > ^^^^^ > > > > > > You're bland... :) > > > > > > > > > > > FreeBSD src repository > > > > > > > > Modified files: > > > > kerberos5/lib/libroken Makefile > > > > Log: > > > > Take signal.c out of sources. > > > > > > > > Reviewed by: nectar > > > > > > Any idea what is causing this yet? Perhaps I missed/overlooked/ignored > > > the discussion? > > > > > > -- > > > Tom Rhodes > > > > We're actively trying to track it down now. No ETA on it being fixed > > at this point, it is probably buried deep inside some perl scripts > > but that's just a guess. We have caught the last couple of examples > > to help try and track it down though (two or three have happened in > > the last two or three days). > > All this magic happens in CVSROOT-src/cfg.pm where $PID for temporary > files and $COMMITTER are set. $PID is probably not the problem but > $COMMITTER seems to be. The text in this variable is put verbatim into > the commit message in CVSROOT-src/log_accum.pl function build_header(). > > I'm not a perl hacker so I can't really comment on the code snipped > below but it looks strange that the first $ENV{} has the environment > variable name in "" and the second one in '' quotes. At least it seems > to be inconsistent. I wonder if we ever can get into the case where > LOGNAME and USER are not set in the users environment. It might be > that for some SSH setups the environment is cleared or altered on > freefall. Nontheless I don't think any of the others should return > anything else than the current username. Unless there is a bug in > the kernel wrt credential handling or some other bug in perl. > > # The username of the committer. > $COMMITTER = $ENV{"LOGNAME"} || $ENV{'USER'} || getlogin > || (getpwuid($<))[0] || sprintf("uid#%d",$<); Hmm... getlogin might be the problem (from perl man page): getlogin Implements the C library function of the same name, which on most systems returns the current login from /etc/utmp, if any. If null, use getpwuid. Using LOGNAME and USER from the environment seems to be pretty unsave as it can be changed by the user to any arbitrary string (or other username). -- Andre