From owner-svn-src-all@FreeBSD.ORG  Thu Dec  6 17:00:54 2012
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id D12BC870;
 Thu,  6 Dec 2012 17:00:54 +0000 (UTC) (envelope-from bright@mu.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
 by mx1.freebsd.org (Postfix) with ESMTP id 802B68FC14;
 Thu,  6 Dec 2012 17:00:54 +0000 (UTC)
Received: from Alfreds-MacBook-Pro-6.local
 (c-67-180-208-218.hsd1.ca.comcast.net [67.180.208.218])
 by elvis.mu.org (Postfix) with ESMTPSA id 1C8741A3C6E;
 Thu,  6 Dec 2012 09:00:54 -0800 (PST)
Message-ID: <50C0CF44.6040802@mu.org>
Date: Thu, 06 Dec 2012 09:00:52 -0800
From: Alfred Perlstein <bright@mu.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Jaakko Heinonen <jh@FreeBSD.org>
Subject: Re: svn commit: r243942 - stable/9/sbin/fsck_msdosfs
References: <201212060835.qB68ZkGe099714@svn.freebsd.org>
In-Reply-To: <201212060835.qB68ZkGe099714@svn.freebsd.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, svn-src-stable-9@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Dec 2012 17:00:55 -0000

On 12/6/12 12:35 AM, Jaakko Heinonen wrote:
> Author: jh
> Date: Thu Dec  6 08:35:46 2012
> New Revision: 243942
> URL: http://svnweb.freebsd.org/changeset/base/243942
>
> Log:
>    MFC r242511: Print a newline after the error message.
>    
>    PR:		bin/168447
>
> Modified:
>    stable/9/sbin/fsck_msdosfs/check.c
> Directory Properties:
>    stable/9/sbin/fsck_msdosfs/   (props changed)
>
> Modified: stable/9/sbin/fsck_msdosfs/check.c
> ==============================================================================
> --- stable/9/sbin/fsck_msdosfs/check.c	Thu Dec  6 08:32:28 2012	(r243941)
> +++ stable/9/sbin/fsck_msdosfs/check.c	Thu Dec  6 08:35:46 2012	(r243942)
> @@ -68,6 +68,7 @@ checkfilesys(const char *fname)
>   
>   	if (dosfs < 0) {
>   		perror("Can't open");
> +		printf("\n");
>   		return 8;
>   	}
>   
>

I think perror writes to STDERR, printf to STDOUT.  (am I wrong?)

Does fsck_msdosfs tie the two together?

You might better use warn()?

sorry if this is superfluous concern, it just popped out as potentially 
wrong.

-Alfred