From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Oct 3 04:14:29 2009 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E2A5A106568D; Sat, 3 Oct 2009 04:14:29 +0000 (UTC) (envelope-from datahead4@gmail.com) Received: from mail-px0-f192.google.com (mail-px0-f192.google.com [209.85.216.192]) by mx1.freebsd.org (Postfix) with ESMTP id B1C7C8FC16; Sat, 3 Oct 2009 04:14:29 +0000 (UTC) Received: by pxi30 with SMTP id 30so2443293pxi.7 for ; Fri, 02 Oct 2009 21:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=BW4SXlSyE7nCZr3x7LZe6MXTFbyWMdYTrN35q+M+nj8=; b=fgBNCW5iZkDCAP3GVgusBkRn+0EY98bdJBL6WUcep3ee+NgGfp58XABhVv4+k9SWF8 8hy+g5MJF2Sm5eRqI81nbqpZGI2OJn9R3xln/Ik2n84ai84AdYC3xrHGRcPJTcVETbfd 1xRKCOnU4oImIPErnBtfirLnnflo0Ch/iYz2w= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=aMEujFKnGWGO8fu+ytxQbCQEuI531ofTJE+syfcXuXs3O5/qPTBI41vOJyR8wmhdLG WRAxANJI41Xh+77w2EdhCX6Ak7/IHxr//bC9kGfOf3a2R/ByxZ0CTTtqpj2KDaq0gCav s6F+sRyagzNgEKo+CBAzwwPvyXWSyH3fYjR80= MIME-Version: 1.0 Received: by 10.114.252.14 with SMTP id z14mr4697413wah.84.1254541288533; Fri, 02 Oct 2009 20:41:28 -0700 (PDT) In-Reply-To: <200910031040.28375.Fluffy@fluffy.khv.ru> References: <200910021923.n92JNGb5022670@www.freebsd.org> <200910031040.28375.Fluffy@fluffy.khv.ru> Date: Fri, 2 Oct 2009 22:41:28 -0500 Message-ID: From: Matt To: Dima Panov Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-ports-bugs@freebsd.org, freebsd-gnats-submit@freebsd.org Subject: Re: ports/139315: [MAINTAINER] audio/liblastfm - fix build with custom PREFIX X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Oct 2009 04:14:30 -0000 On Fri, Oct 2, 2009 at 6:40 PM, Dima Panov wrote: > On Saturday 03 October 2009 06:23:16 Matt Tosto wrote: >> >Number: =A0 =A0 =A0 =A0 139315 > >> >> Build failed when custom PREFIX was set due to an incorrect formatting o= f >> =A0the CONFIGURE_ARGS in the port Makefile. =A0Small attached patch corr= ects >> =A0this issue. =A0I'm not entirely sure if ${PREFIX} or ${LOCALBASE} is = the >> =A0proper substitution to use in the Makefile. =A0Confirmation of this w= ould be >> =A0appreciated. >> >> Patch attached with submission follows: >> >> diff -U3 -r ../liblastfm/Makefile /usr/ports/audio/liblastfm/Makefile >> --- ../liblastfm/Makefile =A0 =A0 2009-10-01 10:44:58.000000000 -0500 >> +++ /usr/ports/audio/liblastfm/Makefile =A0 =A0 =A0 2009-09-08 08:45:41.= 000000000 -0500 >> @@ -23,7 +23,7 @@ >> =A0QT_COMPONENTS=3D =A0 =A0 =A0 corelib xml network sql gui qtestlib \ >> =A0 =A0 =A0 =A0 =A0 =A0 =A0 qmake_build moc_build rcc_build uic_build >> =A0HAS_CONFIGURE=3D =A0 =A0 =A0 yes >> -CONFIGURE_ARGS+=3D =A0 =A0 --prefix ${LOCALBASE} --release >> +CONFIGURE_ARGS+=3D =A0 =A0 -release >> =A0MAKE_JOBS_UNSAFE=3D =A0 =A0yes >> >> =A0USE_LDCONFIG=3D =A0 =A0 =A0 =A0yes > > Patch reversed, right? Oops - yes. Patch reversed. Sorry! > > Args order also had a side effect. >