From owner-cvs-all@FreeBSD.ORG  Thu Aug  4 13:07:52 2005
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CADB316A41F;
	Thu,  4 Aug 2005 13:07:52 +0000 (GMT)
	(envelope-from liamfoy@sepulcrum.org)
Received: from moutvdomng.kundenserver.de (moutvdom.kundenserver.de
	[212.227.126.249])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6A12843D45;
	Thu,  4 Aug 2005 13:07:51 +0000 (GMT)
	(envelope-from liamfoy@sepulcrum.org)
Received: from [212.227.126.224] (helo=mrvdomng.kundenserver.de)
	by moutvdomng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1E0fRs-0001vr-00; Thu, 04 Aug 2005 15:07:48 +0200
Received: from host217-43-76-43.range217-43.btcentralplus.com ([217.43.76.43]
	helo=localhost) by mrvdomng.kundenserver.de with esmtp (Exim 3.35 #1)
	id 1E0fRs-0002Db-00; Thu, 04 Aug 2005 15:07:48 +0200
Date: Thu, 4 Aug 2005 14:07:47 +0100
From: "Liam J. Foy" <liamfoy@sepulcrum.org>
To: Bob Willcox <bob@immure.com>
Message-ID: <20050804130747.GA734@anarion>
References: <200505261057.j4QAv4oU071149@repoman.freebsd.org>
	<20050804122313.GA87318@luke.immure.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050804122313.GA87318@luke.immure.com>
User-Agent: Mutt/1.5.8i
Cc: Ollivier Robert <roberto@freebsd.org>, src-committers@freebsd.org,
	cvs-all@freebsd.org, cvs-src@freebsd.org
Subject: Re: cvs commit: src/usr.sbin/chkgrp chkgrp.8 chkgrp.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 04 Aug 2005 13:07:53 -0000

> This change causes NIS /etc/group entries (+ in column one) to be
> flagged in error. There is a PR (bin/82325) open on this with a proposed
> fix, but here is a simpler (almost) one-line version that I'm using:
> 
> Index: chkgrp.c
> ===================================================================
> RCS file: /usr/cvs/FreeBSD/src/usr.sbin/chkgrp/chkgrp.c,v
> retrieving revision 1.9
> diff -u -r1.9 chkgrp.c
> --- chkgrp.c	26 May 2005 10:57:03 -0000	1.9
> +++ chkgrp.c	4 Aug 2005 12:11:03 -0000
> @@ -106,7 +106,8 @@
>  	}
>  
>  	for (cp = f[0] ; *cp ; cp++) {
> -	    if (!isalnum(*cp) && *cp != '.' && *cp != '_' && *cp != '-') {
> +	    if (!isalnum(*cp) && *cp != '.' && *cp != '_' && *cp != '-' &&
> +		    (cp > f[0] || *cp != '+')) {
>  		warnx("%s: line %d: '%c' invalid character", gfn, n, *cp);
>  		e++;
>  	    }
> 
> Maybe someone has the time to commit a fix for this??
> 
> Thanks,
> Bob

Thanks Bob. I'll commit it to dfbsd too.

Cheers,
-- 
		- Liam J. Foy
		liamfoy@sepulcrum.org