Date: Mon, 18 Jan 2016 16:12:11 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Jimmy Olgeni <olgeni@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r404810 - head/devel/elixir-timex Message-ID: <20160118161210.GA67807@FreeBSD.org> In-Reply-To: <alpine.BSF.2.20.1601181512390.16039@backoffice.olgeni.com> References: <201512300841.tBU8fsYI090905@repo.freebsd.org> <20160113153748.GA38723@FreeBSD.org> <alpine.BSF.2.20.1601181512390.16039@backoffice.olgeni.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 18, 2016 at 04:10:23PM +0100, Jimmy Olgeni wrote: > On Wed, 13 Jan 2016, Alexey Dokuchaev wrote: > > On Wed, Dec 30, 2015 at 08:41:54AM +0000, Jimmy Olgeni wrote: > > > New Revision: 404810 > > > URL: https://svnweb.freebsd.org/changeset/ports/404810 > > > > > > [...] > > > @@ -1,7 +1,8 @@ > > > # $FreeBSD$ > > > > > > PORTNAME= timex > > > -DISTVERSION= 1.0.0-rc4 > > > +PORTVERSION= 1.0.0 > > > +PORTEPOCH= 1 > > > > Why did you bump port epoch here? DISTVERSION ensures that resulting > > PORTVERSION is correctly mangled, and used for -betas and -rcs because > > it allows seamless update to subsequent .0 releases: > > > > $ make -V PORTVERSION DISTVERSION=1.0.0-rc4 > > 1.0.0.r4 > > $ pkg version -t 1.0.0.r4 1.0.0 > > < > > I knew about DISTVERSION, but then I figured that 1.0.0.r4 would be greater > than 1.0.0 in the version comparison, and I didn't think about pkg version > -t. And I even thought about it. I surely made a couple more of these > around the same time :( > [...] > > In the meantime, thanks a lot for keeping an eye on things :) It's OK, thanks for getting back (publicly), let's hope that others would read this and not neglect to double check before bumping port epoch next time. :) Take care, ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160118161210.GA67807>