From owner-svn-src-all@FreeBSD.ORG Fri Jan 7 16:06:56 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A88B11065740; Fri, 7 Jan 2011 16:06:56 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id 1E13D8FC16; Fri, 7 Jan 2011 16:06:55 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id p07G6qMd093695 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 7 Jan 2011 18:06:52 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id p07G6qAA033967; Fri, 7 Jan 2011 18:06:52 +0200 (EET) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id p07G6qXx033966; Fri, 7 Jan 2011 18:06:52 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 7 Jan 2011 18:06:52 +0200 From: Kostik Belousov To: Anonymous Message-ID: <20110107160652.GY12599@deviant.kiev.zoral.com.ua> References: <201101071435.p07EZkNU055560__46495.048949919$1294410977$gmane$org@svn.freebsd.org> <8662u0ycsz.fsf@gmail.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="wHYmV+hLPeNaasdK" Content-Disposition: inline In-Reply-To: <8662u0ycsz.fsf@gmail.com> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r217101 - head/lib/libcompiler_rt X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Jan 2011 16:06:56 -0000 --wHYmV+hLPeNaasdK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 07, 2011 at 06:05:16PM +0300, Anonymous wrote: > Konstantin Belousov writes: >=20 > > Author: kib > > Date: Fri Jan 7 14:35:45 2011 > > New Revision: 217101 > > URL: http://svn.freebsd.org/changeset/base/217101 > > > > Log: > > On amd64 and i386, force assembler to mark objects compiled from the > > assembler source for libcompiler_rt as not needed executable stack. T= his > > is done with a hammer instead of properly marking each assembly file > > with section .note.GNU-stack to avoid modifying contributed source. > > =20 > > Discussed with: ed > > > > Modified: > > head/lib/libcompiler_rt/Makefile > > > > Modified: head/lib/libcompiler_rt/Makefile > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/lib/libcompiler_rt/Makefile Fri Jan 7 14:32:29 2011 (r217100) > > +++ head/lib/libcompiler_rt/Makefile Fri Jan 7 14:35:45 2011 (r217101) > > @@ -156,4 +156,10 @@ SYMLINKS+=3Dlibcompiler_rt_p.a ${LIBDIR}/l > > . endif > > .endif > > =20 > > +.if ${MACHINE_CPUARCH} =3D=3D "amd64" || ${MACHINE_CPUARCH} =3D=3D "i3= 86" > > +AFLAGS+=3D--noexecstack > > +ACFLAGS+=3D-Wl,a,--noexecstack > > +.endif >=20 > Typo? -Wl,a,--foo vs. -Wa,--foo. From gcc(1) manpage >=20 > Assembler Option > -Wa,option -Xassembler option >=20 > Linker Options > -Wl,option -Xlinker option Thank you. Should be fixed in r217102. --wHYmV+hLPeNaasdK Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iEYEARECAAYFAk0nOhsACgkQC3+MBN1Mb4jCTACdHTxRpNpkOknLPxTjKg8VzGqR XIoAn1O6dU1kMTuz2mCMyfKyUv9/5fn/ =ON1C -----END PGP SIGNATURE----- --wHYmV+hLPeNaasdK--