Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 5 May 2012 14:11:24 +0300
From:      Konstantin Belousov <kostikbel@gmail.com>
To:        Sergey Kandaurov <pluknet@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Kirk McKusick <mckusick@freebsd.org>
Subject:   Re: svn commit: r234386 - in head/sys: fs/coda fs/ext2fs fs/msdosfs fs/nfsclient kern nfsclient sys ufs/ffs ufs/ufs
Message-ID:  <20120505111124.GW2358@deviant.kiev.zoral.com.ua>
In-Reply-To: <CAE-mSOJmjHL-%2BdLEDeNuhKFKJGMPZa=4wsrjmHw9fUjroVZkOA@mail.gmail.com>
References:  <201204171628.q3HGSM9P089821@svn.freebsd.org> <CAE-mSOJmjHL-%2BdLEDeNuhKFKJGMPZa=4wsrjmHw9fUjroVZkOA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--lTD11Lcb85B6e8hZ
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, May 05, 2012 at 01:00:36PM +0400, Sergey Kandaurov wrote:
> On 17 April 2012 20:28, Kirk McKusick <mckusick@freebsd.org> wrote:
> > Author: mckusick
> > Date: Tue Apr 17 16:28:22 2012
> > New Revision: 234386
> > URL: http://svn.freebsd.org/changeset/base/234386
> >
> > Log:
> > =9AReplace the MNT_VNODE_FOREACH interface with MNT_VNODE_FOREACH_ALL.
> > =9AThe primary changes are that the user of the interface no longer
> > =9Aneeds to manage the mount-mutex locking and that the vnode that
> > =9Ais returned has its mutex locked (thus avoiding the need to check
> > =9Ato see if its is DOOMED or other possible end of life senarios).
> >
> > =9ATo minimize compatibility issues for third-party developers, the
> > =9Aold MNT_VNODE_FOREACH interface will remain available so that this
> > =9Achange can be MFC'ed to 9. Following the MFC to 9, MNT_VNODE_FOREACH
> > =9Awill be removed in head.
> >
> > =9AThe reason for this update is to prepare for the addition of the
> > =9AMNT_VNODE_FOREACH_ACTIVE interface that will loop over just the
> > =9Aactive vnodes associated with a mount point (typically less than
> > =9A1% of the vnodes associated with the mount point).
> >
> > =9AReviewed by: kib
> > =9ATested by: =9A Peter Holm
> > =9AMFC after: =9A 2 weeks
> >
>=20
> Hi.
>=20
> This commit crashes on old nfsclient. Looks like this change is missed.
>=20
> Index: nfsclient/nfs_vfsops.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- nfsclient/nfs_vfsops.c      (revision 235051)
> +++ nfsclient/nfs_vfsops.c      (working copy)
> @@ -1452,6 +1452,7 @@
>                 MNT_IUNLOCK(mp);
>                 return (EBADF);
>         }
> +       MNT_IUNLOCK(mp);
>=20
>         /*
>          * Force stale buffer cache information to be flushed.
>=20
Yes, looks so. And, for the purposes for which the check of MNTK_UNMOUNTF
was added, the interlock of the struct mount is not needed there at all.
I suggest that you just remove MNT_ILOCK/partial MNT_IUNLOCK and commit
the change.

Thanks.

--lTD11Lcb85B6e8hZ
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (FreeBSD)

iEYEARECAAYFAk+lCtsACgkQC3+MBN1Mb4iXXgCdEPwENnO81zunpeJLET7ZENVr
OoAAnj21/9YyyrWjvpj+C+pssi4+Y+De
=ohSf
-----END PGP SIGNATURE-----

--lTD11Lcb85B6e8hZ--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120505111124.GW2358>