From owner-svn-src-head@FreeBSD.ORG Sat May 5 11:11:31 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 62A45106566B; Sat, 5 May 2012 11:11:31 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id EFA028FC0A; Sat, 5 May 2012 11:11:30 +0000 (UTC) Received: from skuns.kiev.zoral.com.ua (localhost [127.0.0.1]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id q45BBO02076502; Sat, 5 May 2012 14:11:24 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5) with ESMTP id q45BBOPX089033; Sat, 5 May 2012 14:11:24 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.5/8.14.5/Submit) id q45BBOuE089032; Sat, 5 May 2012 14:11:24 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 5 May 2012 14:11:24 +0300 From: Konstantin Belousov To: Sergey Kandaurov Message-ID: <20120505111124.GW2358@deviant.kiev.zoral.com.ua> References: <201204171628.q3HGSM9P089821@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="lTD11Lcb85B6e8hZ" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-4.0 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Kirk McKusick Subject: Re: svn commit: r234386 - in head/sys: fs/coda fs/ext2fs fs/msdosfs fs/nfsclient kern nfsclient sys ufs/ffs ufs/ufs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 May 2012 11:11:31 -0000 --lTD11Lcb85B6e8hZ Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, May 05, 2012 at 01:00:36PM +0400, Sergey Kandaurov wrote: > On 17 April 2012 20:28, Kirk McKusick wrote: > > Author: mckusick > > Date: Tue Apr 17 16:28:22 2012 > > New Revision: 234386 > > URL: http://svn.freebsd.org/changeset/base/234386 > > > > Log: > > =9AReplace the MNT_VNODE_FOREACH interface with MNT_VNODE_FOREACH_ALL. > > =9AThe primary changes are that the user of the interface no longer > > =9Aneeds to manage the mount-mutex locking and that the vnode that > > =9Ais returned has its mutex locked (thus avoiding the need to check > > =9Ato see if its is DOOMED or other possible end of life senarios). > > > > =9ATo minimize compatibility issues for third-party developers, the > > =9Aold MNT_VNODE_FOREACH interface will remain available so that this > > =9Achange can be MFC'ed to 9. Following the MFC to 9, MNT_VNODE_FOREACH > > =9Awill be removed in head. > > > > =9AThe reason for this update is to prepare for the addition of the > > =9AMNT_VNODE_FOREACH_ACTIVE interface that will loop over just the > > =9Aactive vnodes associated with a mount point (typically less than > > =9A1% of the vnodes associated with the mount point). > > > > =9AReviewed by: kib > > =9ATested by: =9A Peter Holm > > =9AMFC after: =9A 2 weeks > > >=20 > Hi. >=20 > This commit crashes on old nfsclient. Looks like this change is missed. >=20 > Index: nfsclient/nfs_vfsops.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- nfsclient/nfs_vfsops.c (revision 235051) > +++ nfsclient/nfs_vfsops.c (working copy) > @@ -1452,6 +1452,7 @@ > MNT_IUNLOCK(mp); > return (EBADF); > } > + MNT_IUNLOCK(mp); >=20 > /* > * Force stale buffer cache information to be flushed. >=20 Yes, looks so. And, for the purposes for which the check of MNTK_UNMOUNTF was added, the interlock of the struct mount is not needed there at all. I suggest that you just remove MNT_ILOCK/partial MNT_IUNLOCK and commit the change. Thanks. --lTD11Lcb85B6e8hZ Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (FreeBSD) iEYEARECAAYFAk+lCtsACgkQC3+MBN1Mb4iXXgCdEPwENnO81zunpeJLET7ZENVr OoAAnj21/9YyyrWjvpj+C+pssi4+Y+De =ohSf -----END PGP SIGNATURE----- --lTD11Lcb85B6e8hZ--