From nobody Wed Jul 1 15:35:50 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gr3xz1LQBz6k3Ss for ; Wed, 01 Jul 2026 15:35:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gr3xz0GF8z3VRV for ; Wed, 01 Jul 2026 15:35:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782920151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vjfign0vZ/xKZsoKiBaCSV4r+kMB1NuyI8n5DlpER8U=; b=gaim5PoCnjNrrof1GHYIUe+mTHBV63WeW5ytM7gjhpwAUX6V6WnADT4GRp+ioJxNF8MzjO U263qchLPsuasudHdQ9k9jtPVxkR49CpngdDS93uA3jadQkRcFTNKiiXM9+BJaj27qms7X I+daoNbYROvySVtqenhuLA3hnHlmSucUDW+Kaj6lqK/+6cZRYIdgtPwhfzYt2fFD4cF79F XeAnGUXcjxnVZgx6bEJ5zhbl0ti1B7Epp87GEfP9UDW4cyZDh2CRt3hks+nb945dtrg1xU 4q7bs6ojAJRngKwAu+3LONnG2ZL/vRm2lwmZZ9tTXnhneFPNDUOjzXV7sp75ZQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782920151; a=rsa-sha256; cv=none; b=i4eRfryqicZWXLMCOaDIoiFss6fPhEQaMVggbooOXLR/mMaxNFE2dmVYLRUb0RsNhvqYpu UJwZ0lZbBclAUoltuXq35lav3jM0Q0gRCqniQHdTso3muqheDZ+0AMpnJeQCfol9k8H9ZS 3AEgRrw7lyZ8WGe7qSYhIRY170SmCQReuoAyL1vSJIRnRqtnJx3t59qwM1eAF2Rj5oyDV3 TiNJeo/l1k4U8OmfFI1ldO1IEEzdVk/doE69LqBBUfPCgBjrbjf04sciyMSdIOIAMt6/xx 1OWo4g6xUY4EudA2ju14t+qjKE6UShPft7tzaaooQQLGOkYrJteNsdw91E9iyg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782920151; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vjfign0vZ/xKZsoKiBaCSV4r+kMB1NuyI8n5DlpER8U=; b=NUmgXq5Y+oAb0JGkBGZtHyM0Tjdy9jQvatvueXrmWV9UJrZz5j9cUg/KknbiScdVAtAcV1 fWySCPwnh4PpbEzxD3hklHMk8omfdCWCDiTKvw26xtUBCX6qmigbD+UI1q0xyFxtZ7AeuD 5JRljBv+ZGbC1yPivNtzQWprUN5PWhmGXtHT/J2ekbe3ux7FKya0KJt0LW774lR9GHcIQa 7ub0oJHfIMt/C9ObJhhJOMk4GCCYO/RtaN+MPbfTr1EBN8GpT1o8rsYRHMGcjr0DLrwwzq aBmoufmz3hTdmcg4uRX2lB6YEFTeLvmN4dtvO7k/aQgDsB96A4naH/E0bd6gnA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4gr3xy6NLHz5bP for ; Wed, 01 Jul 2026 15:35:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 3ac75 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 01 Jul 2026 15:35:50 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Mark Johnston Subject: git: 2a4b8fd1dc07 - main - unix: Fix a socket refcount leak in uipc_sendfile_wait() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2a4b8fd1dc070e71fbaab6f12c1c9e4452652aa7 Auto-Submitted: auto-generated Date: Wed, 01 Jul 2026 15:35:50 +0000 Message-Id: <6a4533d6.3ac75.7c686e7b@gitrepo.freebsd.org> The branch main has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=2a4b8fd1dc070e71fbaab6f12c1c9e4452652aa7 commit 2a4b8fd1dc070e71fbaab6f12c1c9e4452652aa7 Author: Mark Johnston AuthorDate: 2026-07-01 15:35:10 +0000 Commit: Mark Johnston CommitDate: 2026-07-01 15:35:16 +0000 unix: Fix a socket refcount leak in uipc_sendfile_wait() Fixes: d15792780760 ("unix: new implementation of unix/stream & unix/seqpacket") Reviewed by: glebius MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D57967 --- sys/kern/uipc_usrreq.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sys/kern/uipc_usrreq.c b/sys/kern/uipc_usrreq.c index ad6d546afa25..0b4e49c7db55 100644 --- a/sys/kern/uipc_usrreq.c +++ b/sys/kern/uipc_usrreq.c @@ -2446,8 +2446,10 @@ uipc_sendfile_wait(struct socket *so, off_t need, int *space) SOCK_RECVBUF_UNLOCK(so2); return (EAGAIN); } - if (!sockref) + if (!sockref) { soref(so2); + sockref = true; + } error = uipc_stream_sbwait(so2, so->so_snd.sb_timeo); if (error == 0 && __predict_false(sb->sb_state & SBS_CANTRCVMORE))