From owner-freebsd-hackers@FreeBSD.ORG Thu Apr 5 09:35:54 2007 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7C29D16A401 for ; Thu, 5 Apr 2007 09:35:54 +0000 (UTC) (envelope-from tevans.uk@googlemail.com) Received: from ug-out-1314.google.com (ug-out-1314.google.com [66.249.92.168]) by mx1.freebsd.org (Postfix) with ESMTP id C904F13C465 for ; Thu, 5 Apr 2007 09:35:53 +0000 (UTC) (envelope-from tevans.uk@googlemail.com) Received: by ug-out-1314.google.com with SMTP id 71so974149ugh for ; Thu, 05 Apr 2007 02:35:52 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=googlemail.com; s=beta; h=domainkey-signature:received:received:subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer; b=ZYYOrWr7ALbn69A+IE24IIAQj9IFIroW8yGbq+rerPptsaZJNu0a9Qw0hlLbC+niC9oWzzbjHglyvKBIMmd0bTmJrV0yLzG2ZZhsF35SxAskmisPGAicSIc80sdu3VVAp0UMZS7fASWYmCqRPvqONd0uLgxZ8euWLwjb1dXa2KM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=beta; h=received:subject:from:to:cc:in-reply-to:references:content-type:date:message-id:mime-version:x-mailer; b=H3TykaYnw8GFMs9566yoU/doO7N474MZH3DMSVsil3AscH1mQddx6TyiWn8gn0aPa/5+W6NbIi8akY/0kgL9CQ1so7dIctsnecBCoDMXlbxn7X4+50cpoGnPGm4X49Hsa8vjQUca0hTAuF2SgoR8OwtrbshARGmNXSFOSCXpfBU= Received: by 10.67.27.15 with SMTP id e15mr2070481ugj.1175763996104; Thu, 05 Apr 2007 02:06:36 -0700 (PDT) Received: from ?127.0.0.1? ( [213.206.147.185]) by mx.google.com with ESMTP id s1sm2705462uge.2007.04.05.02.06.35; Thu, 05 Apr 2007 02:06:35 -0700 (PDT) From: Tom Evans To: Joe Marcus Clarke In-Reply-To: <1175757140.67579.50.camel@shumai.marcuscom.com> References: <1175757140.67579.50.camel@shumai.marcuscom.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-px0LSbLvCzhOS5+eUJbj" Date: Thu, 05 Apr 2007 10:06:33 +0100 Message-Id: <1175763993.1318.23.camel@zoot.mintel.co.uk> Mime-Version: 1.0 X-Mailer: Evolution 2.10.0 FreeBSD GNOME Team Port Cc: freebsd-hackers@FreeBSD.org Subject: Re: Problem with test(1) X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2007 09:35:54 -0000 --=-px0LSbLvCzhOS5+eUJbj Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Thu, 2007-04-05 at 03:12 -0400, Joe Marcus Clarke wrote: > I noticed something weird with test(1) when I ran across a problem port > Makefile. Our test(1) doesn't properly check to make sure there is an > operand argument to unary operators like -f. For example: >=20 > test -f >=20 > Will print "TRUE" on FreeBSD. On Solaris, it will die: >=20 > /usr/bin/test[8]: test: argument expected >=20 > I think this patch is correct in that it does fix the problem, and the > TEST.sh and TEST.csh regression scripts report the same results pre and > post-patch. Comments? >=20 > http://www.marcuscom.com/downloads/text.c.diff >=20 > Joe >=20 He means http://www.marcuscom.com/downloads/test.c.diff --=-px0LSbLvCzhOS5+eUJbj Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.3 (FreeBSD) iD8DBQBGFLwZlcRvFfyds/cRAvkPAJ9oCayA5cR516wtz0xfvsac79OnnQCgn2b1 5LvQhbm+WuW38c/SC8hmcwI= =C1QJ -----END PGP SIGNATURE----- --=-px0LSbLvCzhOS5+eUJbj--