Date: Wed, 12 Jun 2002 14:10:02 -0700 (PDT) From: John Merryweather Cooper <john_m_cooper@yahoo.com> To: freebsd-ports@FreeBSD.org Subject: Re: ports/39203: Unclear BREAK message in port net/samba Message-ID: <200206122110.g5CLA2O19938@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/39203; it has been noted by GNATS. From: John Merryweather Cooper <john_m_cooper@yahoo.com> To: "Lev A. Serebryakov" <lev@serebryakov.spb.ru> Cc: "FreeBSD-gnats-submit@freebsd.org" <FreeBSD-gnats-submit@freebsd.org> Subject: Re: ports/39203: Unclear BREAK message in port net/samba Date: 12 Jun 2002 14:06:04 -0700 This PR certainly clears things up for me! Like the author, I was unhappy to discover Samba "broken" after the change. On Wed, 2002-06-12 at 13:58, Lev A. Serebryakov wrote: > > >Number: 39203 > >Category: ports > >Synopsis: Unclear BREAK message in port net/samba > >Confidential: no > >Severity: non-critical > >Priority: low > >Responsible: freebsd-ports > >State: open > >Quarter: > >Keywords: > >Date-Required: > >Class: change-request > >Submitter-Id: current-users > >Arrival-Date: Wed Jun 12 14:00:05 PDT 2002 > >Closed-Date: > >Last-Modified: > >Originator: Lev A. Serebryakov <lev@serebryakov.spb.ru> > >Release: FreeBSD 4.4-STABLE i386 > >Organization: > >Environment: > System: FreeBSD freebsd.sereb.net 4.4-STABLE FreeBSD 4.4-STABLE #1: Sat Dec 8 13:48:40 MSK 2001 root@freebsd.sereb.net:/usr/obj/usr/src/sys/LEVMAIL i386 > Ports collection: 13 Jun 2002 > > > >Description: > > net/samba port support ACLs only under FreeBSD 5.0-CURRENT. > But new dialog(1)-based configuration script allows to select ACLs > feature on any system. If user selects ACLs on 4.x or other old > system, port systyem (via make(1)) prints this message: > > ===> samba-2.2.4_1 is marked as broken: Requires a recent FreeBSD 5.0-CURRENT. > > And after that `make install' would not work at all. > > User, who doesn't know about how ACLs support is implemented, could not > understand, WHY is samba broken on 4.x. > > I think, message should be replaced with somethin like this: > > ACL support requires a recent FreeBSD 5.0-CURRENT > > or, even better, `scripts/configure.samba' should detect old system > and add `ACL support' checkbox only on new ones. > > I thinke, both of this changes could be done. > > >How-To-Repeat: > > > Try to select ACL support on 4.x system > > > >Fix: > > I don't prepare any pathses, but fix of message is trivial and > fix for script could be like this: > > OSVERSION=`make -V OSVERSION` > if [ ${OSVERSION} -le 500018 ]; then > ACL_PARAM="acl \"With ACL support\" OFF" > else > ACL_PARAM="" > fi > > And after this add ${ACL_PARAM} to dialog(1) command line. > >Release-Note: > >Audit-Trail: > >Unformatted: > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-ports" in the body of the message > -- _ | |V| / ' || MacroHard -- \ \_| | | \_, || the perfection of form over | ----------------------------------|| substance, marketing over | Web: http://www.borgsdemons.com || performance, and greed over | AIM: johnmcooper || design . . . | =====================================================================/ Public Key: http://www.borgsdemons.com/Personal/pgpkey.asc | =====================================================================\ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200206122110.g5CLA2O19938>