From owner-svn-src-head@freebsd.org Sat Jun 10 15:07:21 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2C53EBEF922; Sat, 10 Jun 2017 15:07:21 +0000 (UTC) (envelope-from nyan@FreeBSD.org) Received: from sakura.ccs.furiru.org (sakura.ccs.furiru.org [IPv6:2001:2f0:104:8060::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "sakura.ccs.furiru.org", Issuer "sakura.ccs.furiru.org" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id D9B867C3CB; Sat, 10 Jun 2017 15:07:20 +0000 (UTC) (envelope-from nyan@FreeBSD.org) Received: from localhost (authenticated bits=0) by sakura.ccs.furiru.org (unknown) with ESMTPA id v5AF7E6j094414; Sun, 11 Jun 2017 00:07:17 +0900 (JST) (envelope-from nyan@FreeBSD.org) Date: Sun, 11 Jun 2017 00:07:14 +0900 (JST) Message-Id: <20170611.000714.2063715294250192258.nyan@FreeBSD.org> To: avg@FreeBSD.org Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-head@FreeBSD.org Subject: Re: svn commit: r317591 - head/sys/dev/drm2/radeon From: TAKAHASHI Yoshihiro In-Reply-To: <03e500d5-76b1-fd38-04c6-90d85a2ddfa8@FreeBSD.org> References: <201704290947.v3T9lF0r075921@repo.freebsd.org> <03e500d5-76b1-fd38-04c6-90d85a2ddfa8@FreeBSD.org> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Jun 2017 15:07:21 -0000 In article <03e500d5-76b1-fd38-04c6-90d85a2ddfa8@FreeBSD.org> Andriy Gapon writes: > On 29/04/2017 12:47, Takahashi Yoshihiro wrote: >> Author: nyan >> Date: Sat Apr 29 09:47:15 2017 >> New Revision: 317591 >> URL: https://svnweb.freebsd.org/changeset/base/317591 >> >> Log: >> Add TUNABLE_INT to radeonkms driver parameters. >> They are required by PowerMac G5 DP. >> >> PR: 217852 >> Submitted by: Hiroo Ono >> MFC after: 1 week > > I think that this solution that I had in my private tree is a little bit more > powerful: > https://people.freebsd.org/~avg/radeon_drv-knobs.diff > > The advantage is that it is less intrusive and also provides read-only sysctl in > addition to the tunables. > Also, hw.drm.radeon seems like a better place for the knobs than just drm.radeon. > > Do you mind if I commit this? Sorry for late. I don't mind that your suggestion. But if you will commit the patch, I think that you should apply the same way to the i915 driver. --- TAKAHASHI Yoshihiro