From owner-freebsd-qa@FreeBSD.ORG  Sun Aug 30 13:16:31 2009
Return-Path: <owner-freebsd-qa@FreeBSD.ORG>
Delivered-To: qa@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 576601065676;
	Sun, 30 Aug 2009 13:16:31 +0000 (UTC)
	(envelope-from marc@blackend.org)
Received: from abigail.blackend.org (ns0.blackend.org [82.227.222.164])
	by mx1.freebsd.org (Postfix) with ESMTP id B86638FC18;
	Sun, 30 Aug 2009 13:16:30 +0000 (UTC)
Received: from abigail.blackend.org (localhost [127.0.0.1])
	by abigail.blackend.org (8.13.4/8.13.3) with ESMTP id n7UDGPjv024958;
	Sun, 30 Aug 2009 15:16:25 +0200 (CEST)
	(envelope-from marc@abigail.blackend.org)
Received: (from marc@localhost)
	by abigail.blackend.org (8.13.4/8.13.3/Submit) id n7UDGPBr024957;
	Sun, 30 Aug 2009 15:16:25 +0200 (CEST) (envelope-from marc)
Date: Sun, 30 Aug 2009 15:16:25 +0200
From: Marc Fonvieille <blackend@FreeBSD.org>
To: Eugene Grosbein <eugen@kuzbass.ru>
Message-ID: <20090830131625.GA24582@abigail.blackend.org>
References: <200908301123.n7UBN6M7001670@kuzbass.ru>
	<20090830123408.GC1306@gothic.blackend.org>
	<20090830124006.GA67685@svzserv.kemerovo.su>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090830124006.GA67685@svzserv.kemerovo.su>
X-Useless-Header: blackend.org
X-Operating-System: FreeBSD 4.11-STABLE
User-Agent: Mutt/1.5.9i
Cc: stable@freebd.org, FreeBSD-gnats-submit@FreeBSD.org, qa@FreeBSD.org
Subject: Re: kern/138341: [patch] 8.0-BETA3: nanobsd build broken due to
	sysipc kernel module
X-BeenThere: freebsd-qa@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: FreeBSD Quality Assurance <freebsd-qa.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-qa>,
	<mailto:freebsd-qa-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-qa>
List-Post: <mailto:freebsd-qa@freebsd.org>
List-Help: <mailto:freebsd-qa-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-qa>,
	<mailto:freebsd-qa-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 30 Aug 2009 13:16:31 -0000

On Sun, Aug 30, 2009 at 08:40:07PM +0800, Eugene Grosbein wrote:
> > 
> > I suspect it's the problem I met when I tried to do a
> > 
> > make -DMODULES_WITH_WORLD="YES" buildworld
> > 
> > and many modules were concerned.  See the following patch:
> > 
> > Index: sys/modules/dtrace/lockstat/Makefile
> > ===================================================================
> > --- sys/modules/dtrace/lockstat/Makefile	(revision 196013)
> > +++ sys/modules/dtrace/lockstat/Makefile	(working copy)
> > @@ -5,7 +5,7 @@
> >  KMOD=		lockstat
> >  SRCS=		lockstat.c 
> >  
> > -SRCS+=		vnode_if.h
> > +SRCS+=		vnode_if.h opt_kdtrace.h
> >  
> >  CFLAGS+=	-I${.CURDIR}/../../../cddl/compat/opensolaris \
> >  		-I${.CURDIR}/../../../cddl/contrib/opensolaris/uts/common \
> > Index: sys/modules/sysvipc/sysvsem/Makefile
> > ===================================================================
> > --- sys/modules/sysvipc/sysvsem/Makefile	(revision 196013)
> > +++ sys/modules/sysvipc/sysvsem/Makefile	(working copy)
> > @@ -3,6 +3,6 @@
> >  .PATH: ${.CURDIR}/../../../kern
> >  
> >  KMOD=	sysvsem
> > -SRCS=	sysv_sem.c opt_sysvipc.h
> > +SRCS=	sysv_sem.c opt_sysvipc.h opt_compat.h
> >  
> >  .include <bsd.kmod.mk>
> > Index: sys/modules/sysvipc/sysvmsg/Makefile
> > ===================================================================
> > --- sys/modules/sysvipc/sysvmsg/Makefile	(revision 196013)
> > +++ sys/modules/sysvipc/sysvmsg/Makefile	(working copy)
> > @@ -3,6 +3,6 @@
> >  .PATH: ${.CURDIR}/../../../kern
> >  
> >  KMOD=	sysvmsg
> > -SRCS=	sysv_msg.c opt_sysvipc.h
> > +SRCS=	sysv_msg.c opt_sysvipc.h opt_compat.h
> >  
> >  .include <bsd.kmod.mk>
> > 
> 
> You are right, other modules are concerned and your patch is more complete
> and correct. Vote for commit :-)
>

For info this unbreak things for most of archs but mips and arm which
need more work in sys/modules/Makefile.  However we can already commit
this patch.

-- 
Marc