From owner-cvs-all@FreeBSD.ORG Wed Jun 30 18:58:34 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C591316A4CE; Wed, 30 Jun 2004 18:58:34 +0000 (GMT) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id A756A43D2D; Wed, 30 Jun 2004 18:58:34 +0000 (GMT) (envelope-from csjp@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.11/8.12.11) with ESMTP id i5UIwJ8s047721; Wed, 30 Jun 2004 18:58:19 GMT (envelope-from csjp@repoman.freebsd.org) Received: (from csjp@localhost) by repoman.freebsd.org (8.12.11/8.12.11/Submit) id i5UIwJkB047720; Wed, 30 Jun 2004 18:58:19 GMT (envelope-from csjp) Message-Id: <200406301858.i5UIwJkB047720@repoman.freebsd.org> From: "Christian S.J. Peron" Date: Wed, 30 Jun 2004 18:58:19 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/libexec/tftpd tftpd.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jun 2004 18:58:34 -0000 csjp 2004-06-30 18:58:19 UTC FreeBSD src repository Modified files: libexec/tftpd tftpd.c Log: The call to setuid(2) subsequently causes setgroups(2) to fail. setgroups(2) requires super-user access in order to complete successfully. Move setgroups(2) to execute before setuid(2) so that it is successful. Revision Changes Path 1.33 +2 -2 src/libexec/tftpd/tftpd.c