From owner-freebsd-stable  Fri Aug  3  8:53:55 2001
Delivered-To: freebsd-stable@freebsd.org
Received: from mail-blue.research.att.com (mail-blue.research.att.com [135.207.30.102])
	by hub.freebsd.org (Postfix) with ESMTP
	id 516FB37B401; Fri,  3 Aug 2001 08:53:53 -0700 (PDT)
	(envelope-from fenner@research.att.com)
Received: from alliance.research.att.com (alliance.research.att.com [135.207.26.26])
	by mail-blue.research.att.com (Postfix) with ESMTP
	id 2B9624CE8E; Fri,  3 Aug 2001 11:53:48 -0400 (EDT)
Received: from windsor.research.att.com (windsor.research.att.com [135.207.26.46])
	by alliance.research.att.com (8.8.7/8.8.7) with ESMTP id LAA13207;
	Fri, 3 Aug 2001 11:53:47 -0400 (EDT)
From: Bill Fenner <fenner@research.att.com>
Received: (from fenner@localhost)
	by windsor.research.att.com (8.8.8+Sun/8.8.5) id IAA17847;
	Fri, 3 Aug 2001 08:53:46 -0700 (PDT)
Message-Id: <200108031553.IAA17847@windsor.research.att.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
To: daniel.sobral@tcoip.com.br
Subject: Re: Request for testers: multicast patch
Cc: ru@freebsd.org, mjacob@freebsd.org, stable@freebsd.org
Date: Fri, 3 Aug 2001 08:53:45 -0700
Versions: dmail (solaris) 2.2j/makemail 2.9b
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-stable.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-stable>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-stable>
X-Loop: FreeBSD.ORG


It looks like the patch causes packets not to be sent if
ia == 0.  The inner part of the sendorfree: loop went from

	if (error == 0) {
		update if stats
		call if_output
	}

to

	if (error == 0 && ia) {
		update ia stats
		call if_output
	}

where I think it's more likely correct to do

	if (error == 0) {
		if (ia) update ia state
		call if_output
	}

I realize this bug was just introducd in rev 1.131, but let's not propogate
it to stable.

  Bill

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message