From owner-svn-src-projects@freebsd.org Thu Dec 24 00:02:05 2015 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EB124A5025D for ; Thu, 24 Dec 2015 00:02:05 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pa0-x234.google.com (mail-pa0-x234.google.com [IPv6:2607:f8b0:400e:c03::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CC0951EBA; Thu, 24 Dec 2015 00:02:05 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pa0-x234.google.com with SMTP id cy9so57508511pac.0; Wed, 23 Dec 2015 16:02:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=ZxsTfC98Z5yq+DbSR4wA/CfzVS0wVWTp6dmE/Xg46Y0=; b=bRTsqLCXOgyEfgF2FEodho1tKTV0pg2LJ7QQa7vgYDeVixYgY4BqC8NzUv4ccU3nQb ju1aoOIylkCTJrz7lG52SRUoYMoXXamJqhl9vAXn5+nQsKrBZgLFE+3b9xFgXAylwZ7/ bp1sQC6XwG/57/DXtcwF4ZRfJzlERgyFOjvfopmkx4jrTh3oQZygP7DsWdb70/J3G4St Z5k2/hxQKp2L5OeXOyR9PYa3jy8ZTpBhMh3n0F6W4wvLeIjQK3XeR4BYF1TgnIXl+FC6 PDiGew3RlQm8e8UBf6u3PGxUp1Kra0KEWF2spezxJtb/3SUpHBQM755zB9GSbWKQFfw9 OwtA== X-Received: by 10.66.227.35 with SMTP id rx3mr47934361pac.3.1450915325148; Wed, 23 Dec 2015 16:02:05 -0800 (PST) Received: from ?IPv6:2601:601:800:126d:6572:283a:84b7:ac98? ([2601:601:800:126d:6572:283a:84b7:ac98]) by smtp.gmail.com with ESMTPSA id 21sm50190694pfs.42.2015.12.23.16.02.03 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 23 Dec 2015 16:02:03 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2104\)) Subject: Re: svn commit: r292675 - projects/zfsd/head/share/mk From: NGie Cooper In-Reply-To: <201512232335.tBNNZXra019877@repo.freebsd.org> Date: Wed, 23 Dec 2015 16:02:01 -0800 Cc: src-committers@freebsd.org, svn-src-projects@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201512232335.tBNNZXra019877@repo.freebsd.org> To: Alan Somers X-Mailer: Apple Mail (2.2104) X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Dec 2015 00:02:06 -0000 > On Dec 23, 2015, at 15:35, Alan Somers wrote: >=20 > Author: asomers > Date: Wed Dec 23 23:35:32 2015 > New Revision: 292675 > URL: https://svnweb.freebsd.org/changeset/base/292675 >=20 > Log: > Fix typo from r292666 >=20 > Sponsored by: Spectra Logic Corp >=20 > Modified: > projects/zfsd/head/share/mk/atf.test.mk >=20 > Modified: projects/zfsd/head/share/mk/atf.test.mk > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- projects/zfsd/head/share/mk/atf.test.mk Wed Dec 23 22:45:17 2015 = (r292674) > +++ projects/zfsd/head/share/mk/atf.test.mk Wed Dec 23 23:35:32 2015 = (r292675) > @@ -95,7 +95,7 @@ CLEANFILES+=3D ${_T} ${_T}.tmp > ATF_TESTS_KSH93_SED_${_T}?=3D # empty > ATF_TESTS_KSH93_SRC_${_T}?=3D ${_T}.sh > ${_T}: ${ATF_TESTS_KSH93_SRC_${_T}} > - echo '#! /usr/libexec/atf-sh' > ${.TARGET}.tmp > + echo '#! /usr/libexec/atf-ksh93' > ${.TARGET}.tmp > .if empty(ATF_TESTS_KSH93_SED_${_T}) > cat ${.ALLSRC:N*Makefile*} >>${.TARGET}.tmp > .else Hi Alan, I=E2=80=99ve been watching some of these commits =E2=80=94 I was = wondering if you=E2=80=99d be for taking all of the IllumOS specific = testcase logic out of atf.test.mk (to keep it =E2=80=9Cclean=E2=80=9D = per se) and be open to putting this into a separate .test.mk file, = similar to the one that Mark Johnston started for dtrace: = ^/head/cddl/usr.sbin/dtrace/tests/dtrace.test.mk ? Thanks! -NGie=