From owner-svn-src-all@freebsd.org Tue Aug 21 20:11:12 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3BDAC107E1E4; Tue, 21 Aug 2018 20:11:12 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E238494960; Tue, 21 Aug 2018 20:11:11 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from mail-lj1-f174.google.com (mail-lj1-f174.google.com [209.85.208.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 8345ADF3F; Tue, 21 Aug 2018 20:11:11 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-lj1-f174.google.com with SMTP id m84-v6so3417380lje.10; Tue, 21 Aug 2018 13:11:11 -0700 (PDT) X-Gm-Message-State: APzg51D837iEkJAr0HqxJ2/kCEbX+oVNQHY1NefBauVquFfR4/jupGBS +AkPg4RR1zc60YBaKJsFhbzAFw7Nv5Yv6ULrPzQ= X-Google-Smtp-Source: ANB0VdY/StZZbbp4Npuuqbu+GN+g71QgR4652ZYy3DC+VRq2AFhiwwn8zeh7fkXHC6wyDqcsdA3F7znpRqx/BU7DJr4= X-Received: by 2002:a2e:658a:: with SMTP id e10-v6mr1106992ljf.99.1534882270016; Tue, 21 Aug 2018 13:11:10 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a2e:91d2:0:0:0:0:0 with HTTP; Tue, 21 Aug 2018 13:10:49 -0700 (PDT) In-Reply-To: <20180821182649.GB25927@spindle.one-eyed-alien.net> References: <201808171619.w7HGJlZe015255@repo.freebsd.org> <29d939de-108e-c7c4-b4b6-4a7772dca2eb@freebsd.org> <20180821182649.GB25927@spindle.one-eyed-alien.net> From: Kyle Evans Date: Tue, 21 Aug 2018 15:10:49 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r337978 - in head/libexec/rtld-elf: . aarch64 arm mips powerpc powerpc64 riscv To: Brooks Davis Cc: Michal Meloun , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Aug 2018 20:11:12 -0000 On Tue, Aug 21, 2018 at 1:26 PM, Brooks Davis wrote: > On Mon, Aug 20, 2018 at 08:08:01PM +0200, Michal Meloun wrote: >> >> On 20.08.2018 18:02, Kyle Evans wrote: >> > On Mon, Aug 20, 2018 at 11:00 AM, Michal Meloun wrote: >> >> >> >> On 17.08.2018 18:19, Brooks Davis wrote: >> >>> Author: brooks >> >>> Date: Fri Aug 17 16:19:47 2018 >> >>> New Revision: 337978 >> >>> URL: https://svnweb.freebsd.org/changeset/base/337978 >> >>> >> >>> Log: >> >>> Rework rtld's TLS Variant I implementation to match r326794 >> >>> >> >>> The above commit fixed handling overaligned TLS segments in libc's >> >>> TLS Variant I implementation, but rtld provides its own implementation >> >>> for dynamically-linked executables which lacks these fixes. Thus, >> >>> port these changes to rtld. >> >>> >> >>> Submitted by: James Clarke >> >>> Reviewed by: kbowling >> >>> Testing byL kbowling (powerpc64), br (riscv), kevans (armv7) >> >>> Obtained from: CheriBSD >> >>> Sponsored by: DARPA, AFRL >> >>> Differential Revision: https://reviews.freebsd.org/D16510 >> >>> >> >>> Modified: >> >>> head/libexec/rtld-elf/aarch64/rtld_machdep.h >> >>> head/libexec/rtld-elf/arm/rtld_machdep.h >> >>> head/libexec/rtld-elf/mips/rtld_machdep.h >> >>> head/libexec/rtld-elf/powerpc/rtld_machdep.h >> >>> head/libexec/rtld-elf/powerpc64/rtld_machdep.h >> >>> head/libexec/rtld-elf/riscv/rtld_machdep.h >> >>> head/libexec/rtld-elf/rtld.c >> >>> >> >> This commit breaks TLS handling for (at least) armv7. Can you please >> >> revert it until I will be able to identify where is problem? >> >> In my case, the libc _ThreadRuneLocale symbol is not zero on program start. >> >> >> > >> > Interesting that I didn't hit this on my armv7 test >> > >> >> No idea yet. For me, it breaks all ctype (isspace()..) related function. >> Originally, I found that bash port gets broken. Its funny if shell takes >> 'a' as non-alphanumeric character, 'x' as whitespace, ... >> Anyway, give me a while - I need to write testcase because bas is too >> complex for effective debugging. This commit isn't fundamentally bad, it >> works for jemalloc thread local variables so I think that only some edge >> case (tbss handling is my candidate) is affected. > > Reverted in r338149. > > It's quite surprising to me that the system would boot in this state. > Is there anything non-default about your build environment? > It seems more likely that there's something terribly wrong with my build environment, but I haven't quite picked out what yet. =(