From owner-cvs-all@FreeBSD.ORG Sun Oct 5 06:44:59 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1637F16A4B3; Sun, 5 Oct 2003 06:44:59 -0700 (PDT) Received: from arginine.spc.org (arginine.spc.org [195.206.69.236]) by mx1.FreeBSD.org (Postfix) with ESMTP id DB9E643F85; Sun, 5 Oct 2003 06:44:57 -0700 (PDT) (envelope-from bms@spc.org) Received: from localhost (localhost [127.0.0.1]) by arginine.spc.org (Postfix) with ESMTP id 7908B65480; Sun, 5 Oct 2003 14:44:56 +0100 (BST) Received: from arginine.spc.org ([127.0.0.1]) by localhost (arginine.spc.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 19337-05; Sun, 5 Oct 2003 14:44:56 +0100 (BST) Received: from saboteur.dek.spc.org (unknown [81.3.72.68]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by arginine.spc.org (Postfix) with ESMTP id D4AE56549C; Sun, 5 Oct 2003 14:44:55 +0100 (BST) Received: by saboteur.dek.spc.org (Postfix, from userid 1001) id 2205514; Sun, 5 Oct 2003 14:44:50 +0100 (BST) Date: Sun, 5 Oct 2003 14:44:50 +0100 From: Bruce M Simpson To: Don Lewis Message-ID: <20031005134450.GC13164@saboteur.dek.spc.org> Mail-Followup-To: Don Lewis , src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org References: <200310050937.h959bldI091908@repoman.freebsd.org> <200310051226.h95CQJN1049247@gw.catspoiler.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200310051226.h95CQJN1049247@gw.catspoiler.org> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_sysctl.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Oct 2003 13:44:59 -0000 On Sun, Oct 05, 2003 at 05:26:19AM -0700, Don Lewis wrote: > In the SMP case the data can change even without pre-emption. There > have been a number of discussions (arch@, smp@, arch-handbook, etc.) > about adding a mutex parameter to the sysctl API. Someone even > submitted a PR with a patch a few months ago (kern/54439), which I had > hoped to review but never found the time to. My GENERIC kernel with vslock() et al. reintroduced, and the pre-emption check in sysctl_handle_opaque(), appears to be OK. I am confident the security issue has now been addressed in -CURRENT (it was limited to sysctl_handle_opaque()), but we now have the larger problem of how to deal with procedural sysctl() handlers in the wider kernel. I can see Peter has encouraged me to open a huge can of worms. Let's continue discussion about what to do on -arch. This has been a learning experience... BMS