From owner-cvs-all@FreeBSD.ORG Wed Aug 2 17:07:14 2006 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 680AA16A4DD; Wed, 2 Aug 2006 17:07:14 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.208.78.105]) by mx1.FreeBSD.org (Postfix) with ESMTP id B267743D5D; Wed, 2 Aug 2006 17:07:12 +0000 (GMT) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.13.7/8.13.7) with ESMTP id k72H7Cbc001358; Wed, 2 Aug 2006 10:07:12 -0700 (PDT) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.13.7/8.13.7/Submit) id k72H7C4L001357; Wed, 2 Aug 2006 10:07:12 -0700 (PDT) (envelope-from sgk) Date: Wed, 2 Aug 2006 10:07:12 -0700 From: Steve Kargl To: Robert Watson Message-ID: <20060802170712.GB970@troutmask.apl.washington.edu> References: <200608021618.k72GI5Bc069006@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200608021618.k72GI5Bc069006@repoman.freebsd.org> User-Agent: Mutt/1.4.2.2i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/netinet tcp_subr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Aug 2006 17:07:14 -0000 On Wed, Aug 02, 2006 at 04:18:05PM +0000, Robert Watson wrote: > > Modified files: > sys/netinet tcp_subr.c > Log: > Move soisdisconnected() in tcp_discardcb() to one of its calling contexts, > tcp_twstart(), but not to the other, tcp_detach(), as the socket is > already being torn down and therefore there are no listeners. This avoids > a panic if kqueue state is registered on the socket at close(), and > eliminates to XXX comments. There is one case remaining in which > tcp_discardcb() reaches up to the socket layer as part of the TCP host > cache, which would be good to avoid. > Thanks! You beat me to my bug report. -- Steve