Skip site navigation (1)Skip section navigation (2) 
Date:      Fri, 19 Jul 2024 16:30:30 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 280298] net/miniupnpc: in 2.2.8 changed API for UPNP_GetValidIGD: build error net-p2p/transmission-components and other
Message-ID:  <bug-280298-7788-y4xqeHYNJ8@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-280298-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-280298-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help 
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D280298

--- Comment #50 from Vladimir Druzenko <vvd@FreeBSD.org> ---
For example net-p2p/monero-cli use it:
    result =3D UPNP_GetValidIGD(deviceList, &urls, &igdData, lanAddress, si=
zeof
lanAddress);
    freeUPNPDevlist(deviceList);
    if (result > 0) {
      if (result =3D=3D 1) {
        std::ostringstream portString;
        portString << port;

        // Delete the port mapping before we create it, just in case we have
dangling port mapping from the daemon not being shu
t down correctly
        UPNP_DeletePortMapping(urls.controlURL, igdData.first.servicetype,
portString.str().c_str(), "TCP", 0);

        int portMappingResult;
        portMappingResult =3D UPNP_AddPortMapping(urls.controlURL,
igdData.first.servicetype, portString.str().c_str(), portString
.str().c_str(), lanAddress, CRYPTONOTE_NAME, "TCP", 0, "0");
        if (portMappingResult !=3D 0) {
          LOG_ERROR("UPNP_AddPortMapping failed, error: " <<
strupnperror(portMappingResult));
        } else {
          MLOG_GREEN(el::Level::Info, "Added IGD port mapping.");
        }
      } else if (result =3D=3D 2) {
        MWARNING("IGD was found but reported as not connected.");
      } else if (result =3D=3D 3) {
        MWARNING("UPnP device was found but not recognized as IGD.");
      } else {
        MWARNING("UPNP_GetValidIGD returned an unknown result code.");
      }

But this was changed:
https://github.com/miniupnp/miniupnp/commit/c0a50ce33e3b99ce8a96fd43049bb5b=
53ffac62f#diff-5a0d7cff00628c2c64a617edb347c0f283e3a75e7df910e7e8438fc6db23=
f610L108

Also better to check upstream patches/issues and get or post patch.

--=20
You are receiving this mail because:
You are the assignee for the bug.=

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-280298-7788-y4xqeHYNJ8>