From owner-svn-src-stable@FreeBSD.ORG Mon Jun 24 09:55:38 2013 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 5B5B3E95; Mon, 24 Jun 2013 09:55:38 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id 4D8C319BE; Mon, 24 Jun 2013 09:55:38 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r5O9tbE5020316; Mon, 24 Jun 2013 09:55:37 GMT (envelope-from glebius@svn.freebsd.org) Received: (from glebius@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r5O9tbF8020315; Mon, 24 Jun 2013 09:55:37 GMT (envelope-from glebius@svn.freebsd.org) Message-Id: <201306240955.r5O9tbF8020315@svn.freebsd.org> From: Gleb Smirnoff Date: Mon, 24 Jun 2013 09:55:37 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-9@freebsd.org Subject: svn commit: r252158 - stable/9/sbin/ifconfig X-SVN-Group: stable-9 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 24 Jun 2013 09:55:38 -0000 Author: glebius Date: Mon Jun 24 09:55:37 2013 New Revision: 252158 URL: http://svnweb.freebsd.org/changeset/base/252158 Log: Merge r249897: Don't free memory that is going to be used as error string. PR: bin/178121 Submitted by: Garrett Cooper Modified: stable/9/sbin/ifconfig/iflagg.c Directory Properties: stable/9/sbin/ifconfig/ (props changed) Modified: stable/9/sbin/ifconfig/iflagg.c ============================================================================== --- stable/9/sbin/ifconfig/iflagg.c Mon Jun 24 09:53:43 2013 (r252157) +++ stable/9/sbin/ifconfig/iflagg.c Mon Jun 24 09:55:37 2013 (r252158) @@ -98,10 +98,8 @@ setlagghash(const char *val, int d, int rf.rf_flags |= LAGG_F_HASHL3; else if (strcmp(tok, "l4") == 0) rf.rf_flags |= LAGG_F_HASHL4; - else { - free(str); + else errx(1, "Invalid lagghash option: %s", tok); - } } free(str); if (rf.rf_flags == 0)