From owner-freebsd-bugs@FreeBSD.ORG Wed Feb 5 08:11:12 2014 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4989ABC5 for ; Wed, 5 Feb 2014 08:11:12 +0000 (UTC) Received: from mail-vc0-x22f.google.com (mail-vc0-x22f.google.com [IPv6:2607:f8b0:400c:c03::22f]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 010541BBB for ; Wed, 5 Feb 2014 08:11:11 +0000 (UTC) Received: by mail-vc0-f175.google.com with SMTP id ij19so34821vcb.20 for ; Wed, 05 Feb 2014 00:11:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=wWo/d9PQtDACL/QizH7L6NeZ3gT0q2IrYvUcRLTl1cc=; b=muvIfCHPN5NVTANGwN+a7YBVOfVHCQi44n0c2TO+TUt9bEVtdsWWE9ML7hv8oV/PHm 1+sQO/tt5rbQRoTqUlXYYLswGEspMt6sYb//+X85ygodeBGbKKXMWHqRF8E3QCcTl/Yo 7QB43QeHqO4tesWmBM6PsecK1B23Eiq8lbR0eAFYXLVvvLwWMC/e8UJvbOctHgqKPAkZ XbudCtQrxN38FZehR31HxaMhtEqfyF7XwAWWAzvPCcMoHOIsAdXV5Z2x0hiJcjgy1EPh 1JHj5coQtXqO78r24qMfBKk9mtNfdGJ0ri0kkxZx8/dn5uFP/KB28fEZTp9QAmlAAjCB n71g== X-Received: by 10.221.66.73 with SMTP id xp9mr35618vcb.27.1391587870936; Wed, 05 Feb 2014 00:11:10 -0800 (PST) MIME-Version: 1.0 Sender: cochard@gmail.com Received: by 10.58.188.35 with HTTP; Wed, 5 Feb 2014 00:10:50 -0800 (PST) In-Reply-To: <201402042000.s14K01eo021855@freefall.freebsd.org> References: <201402042000.s14K01eo021855@freefall.freebsd.org> From: =?ISO-8859-1?Q?Olivier_Cochard=2DLabb=E9?= Date: Wed, 5 Feb 2014 09:10:50 +0100 X-Google-Sender-Auth: GhsY90VSj3K1LC032JAgFat2t3o Message-ID: Subject: Re: kern/181497: [kernel] [patch] Add ASLR feature to kernel To: Shawn Webb Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.17 Cc: freebsd-bugs@freebsd.org X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Feb 2014 08:11:12 -0000 On Tue, Feb 4, 2014 at 9:00 PM, Shawn Webb wrote: > The following reply was made to PR kern/181497; it has been noted by GNATS. > > From: Shawn Webb > To: bug-followup@FreeBSD.org, > steven@roothosts.com > > I'm sorry, my patch actually wasn't right. It included other fixes I had = > in my branch for other features and didn't include some of the other = > ASLR bits. Attached is the right patch. > > A kernel without PAX_ASLR option in configuraton file failed: --- imgact_elf.o --- /src/sys/kern/imgact_elf.c:606:20: error: unused variable 'pr' [-Werror,-Wunused-variable] struct prison *pr; /* For ASLR */ ^ There is a missing #ifdef PAX_ASLR arround this line.