From nobody Mon Feb 17 18:02:34 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4YxVql056Fz5nxmm; Mon, 17 Feb 2025 18:02:43 +0000 (UTC) (envelope-from chmeee@has.gonegalt.net) Received: from mail.gonegalt.net (mail.gonegalt.net [208.167.253.104]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4YxVqk4JC4z3hRc; Mon, 17 Feb 2025 18:02:42 +0000 (UTC) (envelope-from chmeee@has.gonegalt.net) Authentication-Results: mx1.freebsd.org; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gonegalt.net; s=dkim; t=1739815355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KkUZTPXqaGiKYCzOkhyEKggeiXson4HAHMcmm+4Ezs0=; b=ujsGEOMsQOSdMtXM1LPay1J03N75kcC4GeXtn9OTcDl/tjmxbrulD6YPAENLIKbBYqM9in 6u2QUj8JdgodSYNyPnZ9ydwhBbnqa4xeWJDF9MG8ROP89aCU/PVAoiTAeMof+vHV0r37Xx UCeCxiZpF+0lOLLa67E8BDvGy5zkvL0= Received: by localhost (OpenSMTPD) with ESMTP id 6aa03838; Mon, 17 Feb 2025 13:02:35 -0500 (EST) Received: from ralga.knownspace ([192.168.1.17]) by mail.gonegalt.net with ESMTPSA id hQLJNrp5s2dGfwAA0J78UA (envelope-from ); Mon, 17 Feb 2025 13:02:34 -0500 Date: Mon, 17 Feb 2025 13:02:34 -0500 From: Justin Hibbits To: Kristof Provost Cc: John Baldwin , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 7e7f88001d7d - main - pf: use time_t for storing time_t values Message-ID: <20250217130234.03d9d25f@ralga.knownspace> In-Reply-To: <1B3E8B07-037B-4DA9-A8D7-81F866078A39@FreeBSD.org> References: <202502141750.51EHoOFm061342@gitrepo.freebsd.org> <5c019c51-949b-4255-bc44-926ac973a1af@FreeBSD.org> <1B3E8B07-037B-4DA9-A8D7-81F866078A39@FreeBSD.org> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.48; powerpc64le-unknown-linux-gnu) List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:20473, ipnet:208.167.224.0/19, country:US] X-Rspamd-Queue-Id: 4YxVqk4JC4z3hRc X-Spamd-Bar: ---- On Mon, 17 Feb 2025 18:08:18 +0100 Kristof Provost wrote: > On 17 Feb 2025, at 16:24, John Baldwin wrote: > > On 2/14/25 12:50, Kristof Provost wrote: =20 > >> The branch main has been updated by kp: > >> > >> URL:=20 > >> https://cgit.FreeBSD.org/src/commit/?id=3D7e7f88001d7dfec83cd7568369be= 6a587d4a51ff > >> > >> commit 7e7f88001d7dfec83cd7568369be6a587d4a51ff > >> Author: Kristof Provost > >> AuthorDate: 2025-02-07 10:29:26 +0000 > >> Commit: Kristof Provost > >> CommitDate: 2025-02-14 17:47:52 +0000 > >> > >> pf: use time_t for storing time_t values > >> No change to the underlying type, so no ABI change. > >> We define __time_t as uint64_t if __LP64__, otherwise=20 > >> uint32_t, > >> and only define __LP64__ if long is 64 bits. > >> In other words: __time_t =3D=3D long. > >> ok henning@ deraadt@ > >> Obtained from: OpenBSD, guenther ,=20 > >> 6c1b69a0ff > >> Sponsored by: Rubicon Communications, LLC ("Netgate") > >> Differential Revision: https://reviews.freebsd.org/D48963 =20 > > > > This is an ABI change on non-i386 32-bit platforms in FreeBSD since=20 > > they > > all use a 64-bit type for time_t that is not the same size as long. > > Not > > sure if the ABI change matters on FreeBSD though? > > =20 > It wasn=E2=80=99t intended to be an ABI change, hence the commit message.= It=20 > appears that=E2=80=99s only correct for x86 though. >=20 > So we=E2=80=99re only talking about armv7 and ppc32, if I=E2=80=99m not f= orgetting=20 > anything. The former is on the removal list already, and the latter > .. well, I don=E2=80=99t know how many users there are. Both are likely t= o be=20 > embedded platforms where the ABI change is going to be even less=20 > relevant (because it really only matters if the kernel and userspace > are not updated together, and these are going to be embedded devices > that are far more likely to have everything updated simultaneously). >=20 > So I=E2=80=99m unsure about what to do. I can revert this and we can just= =20 > carry this (trivial) diff to OpenBSD forever, or we can ignore the > ABI breakage given the above. I=E2=80=99m not inclined to do anything mor= e=20 > involved though. >=20 > Do you have any thoughts? >=20 > Best regards, > Kristof Being the powerpc maintainer, I don't have any issue with this (after all, I'm the one who changed powerpc to 64-bit time_t back in 201x), but it should probably be publicly mentioned that anything that uses these APIs need rebuilt. If it's purely kernel, no user export, then I don't see a problem at all. It's not MFC-able, though. - Justin