From owner-svn-src-head@freebsd.org Sun Mar 5 15:20:49 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7DF4DCF95DD; Sun, 5 Mar 2017 15:20:49 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5D98A180A; Sun, 5 Mar 2017 15:20:49 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1235) id AF9CF655D; Sun, 5 Mar 2017 15:20:48 +0000 (UTC) Date: Sun, 5 Mar 2017 16:20:48 +0100 From: Baptiste Daroussin To: Julian Elischer Cc: rgrimes@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r314693 - head/usr.sbin/rmt Message-ID: <20170305152048.gyilvy7qscqg45hr@ivaldir.net> References: <201703051319.v25DJSGt082916@pdx.rh.CN85.dnsmgr.net> <761e6ecf-89aa-6356-4650-08f3c5c9d6a8@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="37dy46wovsinn4rj" Content-Disposition: inline In-Reply-To: <761e6ecf-89aa-6356-4650-08f3c5c9d6a8@freebsd.org> User-Agent: NeoMutt/20170225 (1.8.0) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Mar 2017 15:20:49 -0000 --37dy46wovsinn4rj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 05, 2017 at 11:11:35PM +0800, Julian Elischer wrote: > On 5/3/17 9:19 pm, Rodney W. Grimes wrote: > > -- Start of PGP signed section. > > > On Sun, Mar 05, 2017 at 04:09:18AM +0000, Rodney W. Grimes wrote: > > > > Author: rgrimes > > > > Date: Sun Mar 5 04:09:18 2017 > > > > New Revision: 314693 > > > > URL: https://svnweb.freebsd.org/changeset/base/314693 > > > >=20 > > > > Log: > > > > Change /etc/rmt symlink from absolute to relative path, > > > > correcting the mistake made in r6499 > > > > Approved by: grehan > > > > MFC after: 1 week > > > >=20 > > > > Modified: > > > > head/usr.sbin/rmt/Makefile > > > >=20 > > > > Modified: head/usr.sbin/rmt/Makefile > > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D > > > > --- head/usr.sbin/rmt/Makefile Sun Mar 5 04:02:47 2017 (r314692) > > > > +++ head/usr.sbin/rmt/Makefile Sun Mar 5 04:09:18 2017 (r314693) > > > > @@ -7,6 +7,6 @@ MAN=3D rmt.8 > > > > # called from /usr/src/etc/Makefile > > > > etc-rmt: > > > > rm -f ${DESTDIR}/etc/rmt > > > > - ln -s ${BINDIR}/rmt ${DESTDIR}/etc/rmt > > > > + ln -s ..${BINDIR}/rmt ${DESTDIR}/etc/rmt > > > I think this should be ${INSTALL_RSYMLINK} ${BINDIR}/rmt ${DESTDIR}/e= tc/rmt > > find /usr/src | xargs grep INSTALL_RSYM > > (no results) > >=20 > > Sorry, no prior work does this, perhaps once I get done sweeping the > > absolutes out of the tree (about 10 or 15 IIRC) a pass can be made to > > sweep all ln -s out and propage this internal bsd.lib.mk function out > > to the rest of the source tree? > >=20 > > find /usr/share/mk/ | xargs grep INSTALL_RSYM > > /usr/share/mk/bsd.own.mk:INSTALL_RSYMLINK?=3D ${INSTALL} ${RSYMLINK} > > /usr/share/mk/bsd.lib.mk: ${INSTALL_RSYMLINK} ${TAG_ARGS:D${TAG_A= RGS},development} ${SHLIB_NAME} ${DESTDIR}${_LIBDIR}/${SHLIB_LINK} > > /usr/share/mk/bsd.lib.mk: ${INSTALL_RSYMLINK} ${TAG_ARGS} ${DESTD= IR}${_SHLIBDIR}/${SHLIB_NAME} \ > > /usr/share/mk/bsd.lib.mk: ${INSTALL_RSYMLINK} ${TAG_ARGS:D${TAG_A= RGS},development} ${DESTDIR}${_SHLIBDIR}/${SHLIB_NAME} \ > > /usr/share/mk/bsd.lib.mk: ${INSTALL_RSYMLINK} ${TAG_ARGS} ${DESTD= IR}${_SHLIBDIR}/${SHLIB_NAME} \ > >=20 > > This is called from within bsd.lib.mk only, do we want to use this for > > all symbolics links in the source tree? If so I would of though the > > person adding this functionality to the .mk files would of made > > a tree sweeping looking for that and making those changes as well. >=20 > I've been playing around with libpathconv which converts abs paths to > relative paths etc. > I'w working on the patch to ln to add the -a and -r options that some oth= er > versions have. >=20 > you can specify an absolute path but ln -r (abspath) will generate a > relative link. > my target was the exact absolute symlinks that you are targeting. >=20 > Work commitments have made me lay down tools but this reminds me to pick = it > up again. > (libpathconv is in the tree at /lib/libpathconv, but I got interrupted ha= lf > way through.. > I'll do the other half.. But install -l rs does exactly that, why adding a new mechanism? and install works with metalog as stated earlier so for the build system it might be be= tter. Which reminds me multiple people have asked you if it won't be a good idea = to merge your libpathconv into libutil rather that having a new library for ju= st 2 functions. DSO has a price and you haven't replied, will you consider mergi= ng it? Best regards, Bapt --37dy46wovsinn4rj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEgOTj3suS2urGXVU3Y4mL3PG3PloFAli8LMwACgkQY4mL3PG3 PlpC+BAAzrjbq9gfY3hD228mnJgMuhJhrmRnJ5usffY1FxkEDD40O+S5aJIUuKEi 8lU5jCW4wI7B34aTQczH1Sd/Q7zOxl88pxBlL6gJlvPcx++mYFD0cPRpiJqWetms MZsQYc1ENT2QxpSUK8NJNAUhJSV0T85ywunF3tcckQu2nFGCnapUjc8pytFa9RCg TNOL1e7PSS2EPW7A2IpKFq9syQ7L7YQ0+seg1RU8t1f5VYJQ1S+eCic/WAwLT56l RmTt0kj75sQ3+B8gxD7yNt3SHBBJFhnI5LGXIbV3h4KdPXs4gnQstOl+dAUbwuvS FNexpssui827iKhRKz/LtaaRXIjIIBVKyQr7eWtAvtpdFUJuDZx5KTUfRQnZe8iq 6qjLog2iSC3Qwd7BrfCbPKCBFRcoV6rk3s9Q9wCi0YHBGGO/7xBeyvXHesT97ZAp BpMG+2sZqEPS/GihOd4+/Rblf2x+n2KR6ZiJrPZYPz1eKGIi9iIWDGcby3++wjxu uVEOQJhC1GlGVuEi4R3Gu13WmcFpHAaBsxjmtlfC5qVtvDcMosaSxfJ5GTF5+y4m TDZKCpe/auBISZQliE16UOB76oDYIJk3I6UTqnX2si9h1zEzRw27EqEX137I3Z84 ItLoGVYfDZZB8/lzXhKUwjWC8Xpban0kdzFA0+BoTpTOjBlPTBo= =8ugM -----END PGP SIGNATURE----- --37dy46wovsinn4rj--