From owner-freebsd-current@FreeBSD.ORG  Wed Mar 17 18:31:14 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 39A4F16A4CE
	for <freebsd-current@freebsd.org>;
	Wed, 17 Mar 2004 18:31:14 -0800 (PST)
Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 1615B43D46
	for <freebsd-current@freebsd.org>;
	Wed, 17 Mar 2004 18:31:12 -0800 (PST)	(envelope-from obrien@NUXI.com)
Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1])
	by TRANG.nuxi.com (8.12.11/8.12.10) with ESMTP id i2I2UlJo006157;
	Wed, 17 Mar 2004 18:30:47 -0800 (PST)
	(envelope-from obrien@dragon.nuxi.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.12.11/8.12.11/Submit) id i2I2UjqW006156;
	Wed, 17 Mar 2004 18:30:45 -0800 (PST)
	(envelope-from obrien)
Date: Wed, 17 Mar 2004 18:30:45 -0800
From: "David O'Brien" <obrien@freebsd.org>
To: Taku YAMAMOTO <taku@cent.saitama-u.ac.jp>
Message-ID: <20040318023045.GE3018@dragon.nuxi.com>
References: <XFMail.20040310213645.conrads@cox.net>
	<4050BBCB.50302@cinci.rr.com>
	<20040312092348.18be60e0.taku@cent.saitama-u.ac.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040312092348.18be60e0.taku@cent.saitama-u.ac.jp>
User-Agent: Mutt/1.4.1i
X-Operating-System: FreeBSD 5.2-CURRENT
Organization: The NUXI BSD Group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
cc: freebsd-current@freebsd.org
Subject: Re: [PATCH] for SCHED_ULE & libpthread issue (was Re: I like
	SCHED_4BSD)
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
Reply-To: obrien@freebsd.org
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Mar 2004 02:31:14 -0000

On Fri, Mar 12, 2004 at 09:23:47AM +0900, Taku YAMAMOTO wrote:
> Until the problem is fully addressed, I will propose following patch
> to be applied. (the least intrusive one attached in the former message)

Do people think we should commit this?
 
> --- sched_ule.c.orig	Fri Feb 13 05:24:48 2004
> +++ sched_ule.c	Fri Feb 13 05:37:53 2004
> @@ -186,7 +186,7 @@
>  #define	SCHED_INTERACTIVE(kg)						\
>      (sched_interact_score(kg) < SCHED_INTERACT_THRESH)
>  #define	SCHED_CURR(kg, ke)						\
> -    (ke->ke_thread->td_priority != kg->kg_user_pri ||			\
> +    (ke->ke_thread->td_priority < kg->kg_user_pri ||			\
>      SCHED_INTERACTIVE(kg))
>  
>  /*
> @@ -1166,11 +1166,8 @@
>  	 */
>  	if ((ke->ke_flags & KEF_ASSIGNED) == 0) {
>  		if (TD_IS_RUNNING(td)) {
> -			if (td->td_proc->p_flag & P_SA) {
> -				kseq_load_rem(KSEQ_CPU(ke->ke_cpu), ke);
> -				setrunqueue(td);
> -			} else 
> -				kseq_runq_add(KSEQ_SELF(), ke);
> +			kseq_load_rem(KSEQ_CPU(ke->ke_cpu), ke);
> +			setrunqueue(td);