From owner-svn-src-head@FreeBSD.ORG  Wed Oct 24 18:41:07 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id BAE714D5;
 Wed, 24 Oct 2012 18:41:07 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com
 [209.85.214.182])
 by mx1.freebsd.org (Postfix) with ESMTP id 4B1788FC0C;
 Wed, 24 Oct 2012 18:41:07 +0000 (UTC)
Received: by mail-ob0-f182.google.com with SMTP id wc20so1012287obb.13
 for <multiple recipients>; Wed, 24 Oct 2012 11:41:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=c6cfnIkiD8aGqTjiIm0aW8BzCShXPyt0bly3ZA5hMUo=;
 b=Pup3p83DpKekynBF8fvHHKYaYqCeB0cSTebHsYcjNHkebXN1ezIr/xvtaTABsE7btm
 xMxUsF2dMhDSFOlIktHWXHNCJ0lEqrqYk7sRYzFV5JkKCaQMZhjKUkP7x2lNVh8Lr89o
 Wcp5ReU5alYXHmGBkUd/SE7G609GrcUW226CPjjrV96uua9ZYoPcFHFoWdgJ4skvXzpR
 Gpesg6vNpQlS3sFbBmUyXIYO96tZ4v+T9L23/hXtJ98xOknkcFe9JxozSMiosBJmthQx
 DUpLdSljHMKdFbyokycE2+hRI0NtpaJNuN2zmIdeIy0tPTeAuRIjId6dnUADWMXn30Eu
 Z6Xw==
MIME-Version: 1.0
Received: by 10.182.45.42 with SMTP id j10mr13463426obm.60.1351104066614; Wed,
 24 Oct 2012 11:41:06 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.76.75.69 with HTTP; Wed, 24 Oct 2012 11:41:06 -0700 (PDT)
In-Reply-To: <201210241836.q9OIafqo073002@svn.freebsd.org>
References: <201210241836.q9OIafqo073002@svn.freebsd.org>
Date: Wed, 24 Oct 2012 11:41:06 -0700
X-Google-Sender-Auth: cf3uMXSvKI5e_zF5xoDvA0AUp9k
Message-ID: <CAJ-VmonpdJ445hXVaoHqFgS0v7QRwqHWodQrVHm2CN9T661www@mail.gmail.com>
Subject: Re: svn commit: r242014 - head/sys/kern
From: Adrian Chadd <adrian@freebsd.org>
To: Jim Harris <jimharris@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Oct 2012 18:41:07 -0000

On 24 October 2012 11:36, Jim Harris <jimharris@freebsd.org> wrote:

>   Pad tdq_lock to avoid false sharing with tdq_load and tdq_cpu_idle.

Ok, but..


>         struct mtx      tdq_lock;               /* run queue lock. */
> +       char            pad[64 - sizeof(struct mtx)];

.. don't we have an existing compile time macro for the cache line
size, which can be used here?



Adrian