From owner-p4-projects  Mon Dec 30 10:46:39 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id A42B137B405; Mon, 30 Dec 2002 10:46:37 -0800 (PST)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5147937B401
	for <perforce@freebsd.org>; Mon, 30 Dec 2002 10:46:37 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E6D3443EC2
	for <perforce@freebsd.org>; Mon, 30 Dec 2002 10:46:36 -0800 (PST)
	(envelope-from cvance@tislabs.com)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.6/8.12.6) with ESMTP id gBUIkafh003685
	for <perforce@freebsd.org>; Mon, 30 Dec 2002 10:46:36 -0800 (PST)
	(envelope-from cvance@tislabs.com)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.12.6/8.12.6/Submit) id gBUIkaSi003682
	for perforce@freebsd.org; Mon, 30 Dec 2002 10:46:36 -0800 (PST)
Date: Mon, 30 Dec 2002 10:46:36 -0800 (PST)
Message-Id: <200212301846.gBUIkaSi003682@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to cvance@tislabs.com using -f
From: Chris Vance <cvance@FreeBSD.org>
Subject: PERFORCE change 22929 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://perforce.freebsd.org/chv.cgi?CH=22929

Change 22929 by cvance@cvance_laptop on 2002/12/30 10:46:27

	Release Giant on error case

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/security/sebsd/ss/fileutils.c#4 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/security/sebsd/ss/fileutils.c#4 (text+ko) ====

@@ -76,8 +76,11 @@
 	mtx_lock(&Giant);	
 	NDINIT(&nd, LOOKUP, LOCKLEAF, pathseg, path, td);
 	error = vn_open(&nd, &fp->FILE_saved_open_flags, 0);
-	if (error)
+	if (error) {
+		mtx_unlock(&Giant);
 		return (NULL);
+	}
+
 	NDFREE(&nd, NDF_ONLY_PNBUF);
 	VOP_UNLOCK(nd.ni_vp, 0, td);
 	mtx_unlock(&Giant);	

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message