From owner-freebsd-current Sun Jan 20 11:38: 6 2002 Delivered-To: freebsd-current@freebsd.org Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by hub.freebsd.org (Postfix) with ESMTP id A3B9F37B405; Sun, 20 Jan 2002 11:38:03 -0800 (PST) Received: by flood.ping.uio.no (Postfix, from userid 2602) id CDD81532C; Sun, 20 Jan 2002 20:38:01 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: "Andrey A. Chernov" Cc: markm@freebsd.org, current@freebsd.org Subject: Re: Step3, pam_opie snprintf bloat fix for review References: <20020120193121.GA23954@nagual.pp.ru> From: Dag-Erling Smorgrav Date: 20 Jan 2002 20:38:01 +0100 In-Reply-To: <20020120193121.GA23954@nagual.pp.ru> Message-ID: Lines: 14 User-Agent: Gnus/5.0808 (Gnus v5.8.8) Emacs/21.1 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG "Andrey A. Chernov" writes: > Bug: > snprintf is large and slow, increasing program size and slowing it down. > Better way is avoid snprintf when it is not neccessary. > > Fix: > Full functionality of snprintf is not needed below, so it is replaced by > much faster strlcpy. Approved (unless Mark has any objections). DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message