From owner-svn-src-head@freebsd.org Wed Feb 21 17:03:06 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 25AC9F159C7; Wed, 21 Feb 2018 17:03:06 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-it0-f48.google.com (mail-it0-f48.google.com [209.85.214.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id ABC3486984; Wed, 21 Feb 2018 17:03:05 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-it0-f48.google.com with SMTP id d10so3073991itj.2; Wed, 21 Feb 2018 09:03:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :from:date:message-id:subject:to:cc:content-transfer-encoding; bh=CqY6p4dJa820/WAYZFvRerX3ahP3ocIbQiAzlkBJbys=; b=TyBFgwFCarEDa8h3O1kr33C/hcQggPE1wjFcuL8PntgY/s5qO4VjCQozz/nZa02Avk Mr1NK+nZytJcatMe9f4m5N7MlBRT1Xtggc7VbnHf2xIAj6zwWXgx+TNBlhm66+JBXmTc oARzR+Q+PJWp6ZeEHCgJiJLYZovQQ12UyrEjql2xmOZrXFDV6XfpIpNp1GOoAJJcld0z nk/m1asEU7sq2PRYyXYdIuT6hnovQnKBYekJKNkTVa7mue3xU3D4NkBWr8U03dIh7mWF DXqDBaGvRk20DyrDTNL1I2E3WJ+QnJHunQDboH0Gp3ElHuf0EKrdOGYb7i24Es7UWIzp yF9A== X-Gm-Message-State: APf1xPA7VDTM/f9AtMQLMkJZQT3K4JECBtBMqyQrICoOZVE75g3LieEe 7532NR6qAvB+pvzBZKCVuuQjzH/J X-Google-Smtp-Source: AH8x224t+0TfepcUu88UBKK/OEgh5NKpn8KIR/IvbqHlw8ExGhuKD4ah8vxqbbIYOrP27n++DNGuHg== X-Received: by 10.36.78.133 with SMTP id r127mr4085513ita.36.1519232578941; Wed, 21 Feb 2018 09:02:58 -0800 (PST) Received: from mail-io0-f172.google.com (mail-io0-f172.google.com. [209.85.223.172]) by smtp.gmail.com with ESMTPSA id i21sm11826206itb.18.2018.02.21.09.02.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Feb 2018 09:02:58 -0800 (PST) Received: by mail-io0-f172.google.com with SMTP id l12so2836482ioc.10; Wed, 21 Feb 2018 09:02:58 -0800 (PST) X-Received: by 10.107.41.16 with SMTP id p16mr4985054iop.173.1519232578342; Wed, 21 Feb 2018 09:02:58 -0800 (PST) MIME-Version: 1.0 Reply-To: cem@freebsd.org Received: by 10.2.30.149 with HTTP; Wed, 21 Feb 2018 09:02:57 -0800 (PST) In-Reply-To: References: <201802200006.w1K067ZL032311@repo.freebsd.org> From: Conrad Meyer Date: Wed, 21 Feb 2018 09:02:57 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r329612 - in head/sys: kern sys To: Andrew Turner Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Feb 2018 17:03:06 -0000 Do you have r329672 yet? Best, Conrad On Wed, Feb 21, 2018 at 7:11 AM, Andrew Turner wrote= : > >> On 20 Feb 2018, at 00:06, Jeff Roberson wrote: >> >> Author: jeff >> Date: Tue Feb 20 00:06:07 2018 >> New Revision: 329612 >> URL: https://svnweb.freebsd.org/changeset/base/329612 >> >> Log: >> Further parallelize the buffer cache. >> >> Provide multiple clean queues partitioned into 'domains'. Each domain = manages >> its own bufspace and has its own bufspace daemon. Each domain has a se= t of >> subqueues indexed by the current cpuid to reduce lock contention on the= cleanq. >> >> Refine the sleep/wakeup around the bufspace daemon to use atomics as mu= ch as >> possible. >> >> Add a B_REUSE flag that is used to requeue bufs during the scan to appr= oximate >> LRU rather than locking the queue on every use of a frequently accessed= buf. >> >> Implement bufspace_reserve with only atomic_fetchadd to avoid loop rest= arts. >> >> Reviewed by: markj >> Tested by: pho >> Sponsored by: Netflix, Dell/EMC Isilon >> Differential Revision: https://reviews.freebsd.org/D14274 > > I=E2=80=99m seeing the following panic on FreeBSD/arm64 after this change= . > > Andrew > > panic: bq_remove: Remove buffer 0xffff00004082f260 from wrong queue. > cpuid =3D 4 > time =3D 1519088201 > KDB: stack backtrace: > db_trace_self() at db_trace_self_wrapper+0x28 > pc =3D 0xffff00000062fee4 lr =3D 0xffff0000000c0450 > sp =3D 0xffff000040364480 fp =3D 0xffff000040364690 > > db_trace_self_wrapper() at vpanic+0x184 > pc =3D 0xffff0000000c0450 lr =3D 0xffff000000354ce8 > sp =3D 0xffff0000403646a0 fp =3D 0xffff000040364720 > > vpanic() at kassert_panic+0x158 > pc =3D 0xffff000000354ce8 lr =3D 0xffff000000354b60 > sp =3D 0xffff000040364730 fp =3D 0xffff0000403647f0 > > kassert_panic() at bq_remove+0x178 > pc =3D 0xffff000000354b60 lr =3D 0xffff0000003f7014 > sp =3D 0xffff000040364800 fp =3D 0xffff000040364810 > > bq_remove() at buf_recycle+0x100 > pc =3D 0xffff0000003f7014 lr =3D 0xffff0000003fca80 > sp =3D 0xffff000040364820 fp =3D 0xffff000040364880 > > buf_recycle() at bufspace_daemon+0xb4 > pc =3D 0xffff0000003fca80 lr =3D 0xffff0000003fd31c > sp =3D 0xffff000040364890 fp =3D 0xffff000040364910 > > bufspace_daemon() at fork_exit+0x7c > pc =3D 0xffff0000003fd31c lr =3D 0xffff000000318388 > sp =3D 0xffff000040364920 fp =3D 0xffff000040364950 > > fork_exit() at fork_trampoline+0x10 > pc =3D 0xffff000000318388 lr =3D 0xffff000000649ec4 > sp =3D 0xffff000040364960 fp =3D 0x0000000000000000 > > KDB: enter: panic