From owner-freebsd-virtualization@freebsd.org Sat Jun 6 03:23:56 2020 Return-Path: Delivered-To: freebsd-virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5082034097C for ; Sat, 6 Jun 2020 03:23:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 49f4cD1SrHz4dZ2 for ; Sat, 6 Jun 2020 03:23:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 32464340CC0; Sat, 6 Jun 2020 03:23:56 +0000 (UTC) Delivered-To: virtualization@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3207E340A27 for ; Sat, 6 Jun 2020 03:23:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49f4cD0ZkFz4dj3 for ; Sat, 6 Jun 2020 03:23:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0F3491B8C1 for ; Sat, 6 Jun 2020 03:23:56 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 0563NtHW034340 for ; Sat, 6 Jun 2020 03:23:55 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 0563NtZg034329 for virtualization@FreeBSD.org; Sat, 6 Jun 2020 03:23:55 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: virtualization@FreeBSD.org Subject: [Bug 246121] [bhyve][PATCH] Append Keyboard Layout specified option for using VNC. Date: Sat, 06 Jun 2020 03:23:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bhyve X-Bugzilla-Version: Unspecified X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: koinec@yahoo.co.jp X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: virtualization@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-virtualization@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "Discussion of various virtualization techniques FreeBSD supports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 06 Jun 2020 03:23:56 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D246121 --- Comment #12 from Koine Yuusuke --- (In reply to Peter Grehan from comment #11) Thank you for responding. I think it is unnecessary to add a translation table from scanset2 to scans= et 1. In the patch suggested this time, the translation process from scanset 2 to scanset 1 is bypassed in the atkbd emulation only when the QEMU Extended Key Event Message is received. (Therefore, an argument that specifies whether scanset conversion is perfor= med is added to the fifo_get() function and fifo_put() function arguments.) There are two reasons for doing this. 1) It is written that a simple 1:1 translation is possible from scanset2 to scanset 1, but I understand the following exceptions. Scanset 2 Scanset 1 ----------------------------- 0x02/0x83 -> 0x41 0x7f/0x84 -> 0x54 There is no problem when tranlating from scanset 2 to scanset 1 as int t= he atkbd emulation, but when performing reverse tranlation, it is the recognit= ion that 0x41/0x54 of scanset 1 cannot determine which value of scanset 2 is se= t. (However, as far as I know, this is only the F7 key(0x83->0x41), so it m= ay not be a problem ...) 2) In bhyve's code, translating from scanset 1 to scanset 2 in ps2kbd.c, a= nd then translating from scanset 2 to scanset 1 in atkbd.c again immediately, = it is=20 considered redundant even if the effect on performance is slight I will. In the future, if we decide to make the atkbd emulation(atkbdc.c) and PS2 virtual keyboard driver(ps2kbd.c) completely independent, I'm aware that th= ere is a problem because the method suggested this time will not be able to make them independent. However, in the current implementation, the function of the PS2 virtual keyboard driver is directly called from the atkbd emulation, so I couldn't understand the future course. If necessary, I can stop the bypass process and add the translation process from scanset 1 to scanset 2. I apologize for the inconvenience, but please would like to know the correspondence policy. --=20 You are receiving this mail because: You are the assignee for the bug.=