From owner-freebsd-net@FreeBSD.ORG  Wed Mar 19 05:44:51 2014
Return-Path: <owner-freebsd-net@FreeBSD.ORG>
Delivered-To: net@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 243575FC
 for <net@FreeBSD.org>; Wed, 19 Mar 2014 05:44:51 +0000 (UTC)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id A1731383
 for <net@FreeBSD.org>; Wed, 19 Mar 2014 05:44:49 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.8/8.14.8) with ESMTP id s2J5iVl0008787
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 19 Mar 2014 09:44:31 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.8/8.14.8/Submit) id s2J5iV1W008786;
 Wed, 19 Mar 2014 09:44:31 +0400 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 19 Mar 2014 09:44:31 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Andrew Rybchenko <Andrew.Rybchenko@oktetlabs.ru>
Subject: Re: [PATCH 1/6] sfxge: fix mbuf leak if it does not fit in software
 queue
Message-ID: <20140319054431.GN1499@glebius.int.ru>
References: <53280DB3.4080900@oktetlabs.ru> <20140318124624.GD1499@FreeBSD.org>
 <53292470.801@oktetlabs.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53292470.801@oktetlabs.ru>
User-Agent: Mutt/1.5.22 (2013-10-16)
Cc: net@FreeBSD.org
X-BeenThere: freebsd-net@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Networking and TCP/IP with FreeBSD <freebsd-net.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-net/>
List-Post: <mailto:freebsd-net@freebsd.org>
List-Help: <mailto:freebsd-net-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-net>,
 <mailto:freebsd-net-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Mar 2014 05:44:51 -0000

On Wed, Mar 19, 2014 at 09:00:32AM +0400, Andrew Rybchenko wrote:
A> Gleb,
A> 
A> On 03/18/2014 04:46 PM, Gleb Smirnoff wrote:
A> >    Andrew,
A> >
A> > On Tue, Mar 18, 2014 at 01:11:15PM +0400, Andrew Rybchenko wrote:
A> > A>
A> > A> sfxge: fix mbuf leak if it does not fit in software queue
A> > A>
A> > A> mbuf should be owned by if_transmit function in any case.
A> > A>
A> > A> Submitted-by:   Andrew Rybchenko <Andrew.Rybchenko@oktetlabs.ru>
A> > A> Sponsored by:   Solarflare Communications, Inc.
A> >
A> > Can we simplify the function while here?
A> One of the next patches (4/6) moves link down check to the function and 
A> uses "fail" label to increment early drops statistics and free mbuf. 
A> IMHO, it is really nice to have single place to do it.

I've replied to 4/6 and to 3/6 as well. Please consider my
suggestions.

If you insist on committing your patches as is, then please resubmit
them as email attachments. When submitting them inlined, your MUA
mangles patches, and they fail to apply.

-- 
Totus tuus, Glebius.