From owner-p4-projects@FreeBSD.ORG  Thu Dec  7 17:52:09 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 1E15B16A47B; Thu,  7 Dec 2006 17:52:09 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BCC0F16A50E;
	Thu,  7 Dec 2006 17:52:08 +0000 (UTC)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.176.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 5C34343D36;
	Thu,  7 Dec 2006 17:49:13 +0000 (GMT)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (localhost [127.0.0.1])
	by eva.fit.vutbr.cz (envelope-from xdivac02@eva.fit.vutbr.cz)
	(8.13.8/8.13.7) with ESMTP id kB7HnxAX033375
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 7 Dec 2006 18:49:59 +0100 (CET)
Received: (from xdivac02@localhost)
	by eva.fit.vutbr.cz (8.13.8/8.13.3/Submit) id kB7HnvWb033371;
	Thu, 7 Dec 2006 18:49:57 +0100 (CET)
Date: Thu, 7 Dec 2006 18:49:57 +0100
From: Divacky Roman <xdivac02@stud.fit.vutbr.cz>
To: Alexander Leidinger <Alexander@leidinger.net>
Message-ID: <20061207174957.GA32960@stud.fit.vutbr.cz>
References: <200612061323.kB6DNgsn098612@repoman.freebsd.org>
	<20061207080829.1vs0y9xxwsc8kkck@webmail.leidinger.net>
	<20061207103755.GA38924@stud.fit.vutbr.cz>
	<20061207120127.119d4mylpckwwwsg@webmail.leidinger.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20061207120127.119d4mylpckwwwsg@webmail.leidinger.net>
User-Agent: Mutt/1.4.2.2i
X-Scanned-By: MIMEDefang 2.57 on 147.229.176.14
Cc: Roman Divacky <rdivacky@FreeBSD.org>,
	Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 111194 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Dec 2006 17:52:09 -0000

On Thu, Dec 07, 2006 at 12:01:27PM +0100, Alexander Leidinger wrote:
> Quoting Divacky Roman <xdivac02@stud.fit.vutbr.cz> (from Thu, 7 Dec  
> 2006 11:37:55 +0100):
> 
> >On Thu, Dec 07, 2006 at 08:08:29AM +0100, Alexander Leidinger wrote:
> >>Quoting Roman Divacky <rdivacky@FreeBSD.org> (from Wed, 6 Dec 2006
> >>13:23:42 GMT):
> >>
> >>>http://perforce.freebsd.org/chv.cgi?CH=111194
> >>>
> >>>Change 111194 by rdivacky@rdivacky_witten on 2006/12/06 13:23:04
> >>>
> >>>	Add an XXX comment about signal delivery in linux_exit_group.
> >>>	We currently ignore sending a signal if SIGNAL_EXIT_GROUP is set
> >>>	condition. We dont even implement this flag....
> >>
> >>What about a printf in case the flag is set? This way we should notice
> >>if it is used somewhere. We could also correlate this with application
> >>misbehavior.
> >
> >we dont even implement the functionality of the flag.
> 
> Yes, and to get a glue how important it is, we should print a message.

you dont understand.. the flag is not passed in or something. its an
internal thing. kernel sets that under some conditions...