From owner-p4-projects@FreeBSD.ORG  Mon Apr 21 10:22:02 2003
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 1B97B37B43B; Mon, 21 Apr 2003 10:22:02 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8DB2337B425
	for <perforce@freebsd.org>; Mon, 21 Apr 2003 10:22:01 -0700 (PDT)
Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 868D743FD7
	for <perforce@freebsd.org>; Mon, 21 Apr 2003 10:22:00 -0700 (PDT)
	(envelope-from jhb@FreeBSD.org)
Received: (qmail 7544 invoked from network); 21 Apr 2003 17:22:03 -0000
Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63])
	(envelope-sender <jhb@FreeBSD.org>)encrypted SMTP
	for <perforce@freebsd.org>; 21 Apr 2003 17:22:03 -0000
Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1])
	by server.baldwin.cx (8.12.8/8.12.8) with ESMTP id h3LHLuOv090319;
	Mon, 21 Apr 2003 13:21:56 -0400 (EDT)
	(envelope-from jhb@FreeBSD.org)
Message-ID: <XFMail.20030421132200.jhb@FreeBSD.org>
X-Mailer: XFMail 1.5.4 on FreeBSD
X-Priority: 3 (Normal)
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
In-Reply-To: <200304210513.h3L5DwwN098360@repoman.freebsd.org>
Date: Mon, 21 Apr 2003 13:22:00 -0400 (EDT)
From: John Baldwin <jhb@FreeBSD.org>
To: Marcel Moolenaar <marcel@FreeBSD.org>
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: RE: PERFORCE change 29330 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Apr 2003 17:22:03 -0000


On 21-Apr-2003 Marcel Moolenaar wrote:
> http://perforce.freebsd.org/chv.cgi?CH=29330
> 
> Change 29330 by marcel@marcel_nfs on 2003/04/20 22:13:14
> 
>       Remove the debugging printf and invert the condition so that the
>       flow of control is slightly less weird.
> 
> Affected files ...
> 
> .. //depot/projects/ia64_epc/sys/ia64/ia64/trap.c#11 edit
> 
> Differences ...
> 
> ==== //depot/projects/ia64_epc/sys/ia64/ia64/trap.c#11 (text+ko) ====
> 
> @@ -317,12 +317,10 @@
>  {
>       while (1) {
>               disable_intr();
> -             if (curthread->td_flags & (TDF_ASTPENDING|TDF_NEEDRESCHED)) {
> -                     enable_intr();
> -                     printf("XXX calling ast()\n");
> -                     ast(tf);
> -             } else
> +             if (!(curthread->td_flags & (TDF_ASTPENDING|TDF_NEEDRESCHED)))
>                       break;
> +             enable_intr();
> +             ast(tf);
>       }
>       /* Keep interrupts disabled. */
>  }

Perhaps:

        disable_intr();
        while (curthread->td_flags & (TDF_ASTPENDING|TDF_NEEDRESCHED)) {
                enable_intr();
                ast(tf);
                disable_intr();
        }

would be even clearer? :)

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/