From owner-cvs-all@FreeBSD.ORG Wed Jun 30 19:00:52 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B55116A4CE; Wed, 30 Jun 2004 19:00:51 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D128543D41; Wed, 30 Jun 2004 19:00:51 +0000 (GMT) (envelope-from csjp@freebsd.org) Received: from freefall.freebsd.org (csjp@localhost [127.0.0.1]) i5UJ0Q5c076406; Wed, 30 Jun 2004 19:00:26 GMT (envelope-from csjp@freebsd.org) Received: (from csjp@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i5UJ0QBV076405; Wed, 30 Jun 2004 19:00:26 GMT (envelope-from csjp@freebsd.org) X-Authentication-Warning: freefall.freebsd.org: csjp set sender to csjp@freebsd.org using -f Date: Wed, 30 Jun 2004 19:00:25 +0000 From: "Christian S.J. Peron" To: src-committers@freebsd.org, cvs-src@freebsd.org, cvs-all@freebsd.org Message-ID: <20040630190025.GA68862@freefall.freebsd.org> References: <200406301858.i5UIwJkB047720@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200406301858.i5UIwJkB047720@repoman.freebsd.org> User-Agent: Mutt/1.4.1i Subject: Re: cvs commit: src/libexec/tftpd tftpd.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Jun 2004 19:00:52 -0000 On 30 Jun 2004 Christian S.J. Peron wrote: > csjp 2004-06-30 18:58:19 UTC > > FreeBSD src repository > > Modified files: > libexec/tftpd tftpd.c > Log: > The call to setuid(2) subsequently causes setgroups(2) to fail. setgroups(2) > requires super-user access in order to complete successfully. > Move setgroups(2) to execute before setuid(2) so that it is successful. > > Revision Changes Path > 1.33 +2 -2 src/libexec/tftpd/tftpd.c Whoops, forgot: Approved by: bmilekic (mentor)