From owner-svn-src-head@freebsd.org  Thu Jul  5 14:56:26 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7C512103088A;
 Thu,  5 Jul 2018 14:56:26 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 19FCB80E58;
 Thu,  5 Jul 2018 14:56:26 +0000 (UTC) (envelope-from jhb@FreeBSD.org)
Received: from John-Baldwins-MacBook-Pro-2.local (ralph.baldwin.cx
 [66.234.199.215])
 by mail.baldwin.cx (Postfix) with ESMTPSA id 177B810A87D;
 Thu,  5 Jul 2018 10:56:23 -0400 (EDT)
Subject: Re: svn commit: r335916 - head/sys/conf
To: Konstantin Belousov <kostikbel@gmail.com>, Matt Macy <mmacy@FreeBSD.org>
References: <201807032305.w63N5guY063293@repo.freebsd.org>
 <20180704142233.GB5562@kib.kiev.ua>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
From: John Baldwin <jhb@FreeBSD.org>
Message-ID: <6e5bc5e4-052c-877f-1c36-c72e276ff045@FreeBSD.org>
Date: Thu, 5 Jul 2018 07:56:22 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0)
 Gecko/20100101 Thunderbird/52.8.0
MIME-Version: 1.0
In-Reply-To: <20180704142233.GB5562@kib.kiev.ua>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Thu, 05 Jul 2018 10:56:24 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Jul 2018 14:56:26 -0000

On 7/4/18 7:22 AM, Konstantin Belousov wrote:
> On Tue, Jul 03, 2018 at 11:05:42PM +0000, Matt Macy wrote:
>> Author: mmacy
>> Date: Tue Jul  3 23:05:42 2018
>> New Revision: 335916
>> URL: https://svnweb.freebsd.org/changeset/base/335916
>>
>> Log:
>>   Enable MODULE_TIED by default for modules compiled with the kernel
> But why ?

I think we should enable KLD_TIED to inline critical_* etc. for modules
built as part of a kernel that are installed alongside the kernel in /boot/<kerneldir>.
I don't think we need to support modules built with kernel A loaded into kernel B.

I think we should not enable it for "standalone" module builds done in ports or via
"cd /sys/modules/foo; make" that install to /boot/modules so that those modules can
work with different kernels.  This still permits someone to load a module into kernel
A that they had disabled in kernel A's config file (via NO_MODULES or MODULES_OVERRIDE
or some such) by doing 'cd /sys/modules/foo; make; make load'.

-- 
John Baldwin