From nobody Wed Apr 22 14:20:12 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g11b04KCWz6ZdZB for ; Wed, 22 Apr 2026 14:20:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g11b03djmz3fW4 for ; Wed, 22 Apr 2026 14:20:12 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776867612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bQ3TlJ7URChJtVJfqVJZFrCGH2bnV8GlJg8547e9GYY=; b=WIOB27Ci04d0TZBcDiv1wcPllmd8BYeydrDdiO//CxB2eytdorA2UHJ+qLp4G68Qw8pswp ln2GoWGUta29ieWGkqRRfTFUHI/xxyITs01tr4NL3EQF0FktN4EB4xjF3gdv16wN/+MzJ2 FeOQPPOo7ozpdBLYuoosdgOVm41L2q9gQUIuTHXbI1zQd52vwnZWIpEyIUU+PbCLUAV8Ie 4kIBY4jzbbjcv4UUYzQpv2sLHaLFwf+7C3AQxpej6bJ6uBiIRgNkcvMTy1fu6EvIuW47nM /28IRZF4x0qweQJA3APDBtklv/yT4mXqNSlSLJ9h/vECTfEWA93m6grplkSy6Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776867612; a=rsa-sha256; cv=none; b=U4faEt284ZG3aPB1yeyhlW1y1aQTd0xK8NOd+hk0S92tVwHf5pIWAZl9KGsXk5JUL9Lm+Y qkpL3JwKWCa/SgWD7vMpnTLfta2RVgzxJ8CAFPzEIQ83gJkC4E6w8rQcmmexmKiyr1ksZJ Upnji8FZEhp618ZHiuELItyBN2M+sNqCY/EAQsTedcenLEq/6abLuNMxa0SX7i0WVi90qJ 7FFVhPy/IrkqPiiyTouq0tZQvj0tmSu9xMPwuBecfxxL0wn9IMyg5K1LBxx1gAQe2NdoAD kBfTnCh9YN0VRELS+GFfdFR13FuZ6jn1m9e2IGb6YzziDcsoIjg0wfiMujaFVA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776867612; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=bQ3TlJ7URChJtVJfqVJZFrCGH2bnV8GlJg8547e9GYY=; b=UsVLePa93PjDaAFgrVv3f3LwXF8mhIBih/AZKr5Mlyba2IfpnscDszIoMd5hpS+7r7ftj2 e0LkvltUgdXntEOck4iqdmYrVameXnstVLHWuHFj7YUG8pRvTIACJxJ8c/9033Ef7Eo12V lCHdbSGhYNS++q6wGgX+jgDArUGtBYDJ7+FuwdbqI11kyjpj3LIZAnvVyP+xmYDo6Hvp+z 3vD4SGM30/3CtB61anP+LgiNgPMAnzxHqgDy9N2VfDxscInWuzuPPzS4WWH0PfFP5Yxfgw hwtlyWT1yAU9zuGnIE3TvSkT5UZ/oJy8ggWjNHtXpwELpoZc+qmfeEQW+QdbUg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g11b02nGMzZp0 for ; Wed, 22 Apr 2026 14:20:12 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 25d28 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 22 Apr 2026 14:20:12 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Johan=?utf-8?Q? S=C3=B6llv?=ander Subject: git: 51b65c6af2e1 - main - ctladm tests: Only use allowed chars in IQN List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: js X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 51b65c6af2e19f1e944c67aa2b5252cd9dc9e2f7 Auto-Submitted: auto-generated Date: Wed, 22 Apr 2026 14:20:12 +0000 Message-Id: <69e8d91c.25d28.39978b0e@gitrepo.freebsd.org> The branch main has been updated by js: URL: https://cgit.FreeBSD.org/src/commit/?id=51b65c6af2e19f1e944c67aa2b5252cd9dc9e2f7 commit 51b65c6af2e19f1e944c67aa2b5252cd9dc9e2f7 Author: Johan Söllvander AuthorDate: 2026-04-22 14:19:42 +0000 Commit: Johan Söllvander CommitDate: 2026-04-22 14:19:42 +0000 ctladm tests: Only use allowed chars in IQN _ isn't part of the allowed IQN format, but - is. None functional change. Reviewed by: asomers, ngie Approved by: asomers (mentor) MFC after: 1 week Sponsored by: ConnectWise Differential Revision: https://reviews.freebsd.org/D56557 --- usr.sbin/ctladm/tests/port.sh | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/usr.sbin/ctladm/tests/port.sh b/usr.sbin/ctladm/tests/port.sh index d966529a85ae..1103a1d7bafb 100644 --- a/usr.sbin/ctladm/tests/port.sh +++ b/usr.sbin/ctladm/tests/port.sh @@ -118,7 +118,7 @@ create_iscsi_body() { skip_if_ctld - TARGET=iqn.2018-10.myhost.create_iscsi + TARGET=iqn.2018-10.myhost.create-iscsi atf_check -o save:port-create.txt ctladm port -c -d "iscsi" -O cfiscsi_portal_group_tag=$PGTAG -O cfiscsi_target="$TARGET" echo "target: $TARGET" >> port-create.txt atf_check egrep -q "Port created successfully" port-create.txt @@ -146,7 +146,7 @@ create_iscsi_alias_body() { skip_if_ctld - TARGET=iqn.2018-10.myhost.create_iscsi_alias + TARGET=iqn.2018-10.myhost.create-iscsi-alias ALIAS="foobar" atf_check -o save:port-create.txt ctladm port -c -d "iscsi" -O cfiscsi_portal_group_tag=$PGTAG -O cfiscsi_target="$TARGET" -O cfiscsi_target_alias="$ALIAS" echo "target: $TARGET" >> port-create.txt @@ -173,7 +173,7 @@ create_iscsi_without_required_args_body() { skip_if_ctld - TARGET=iqn.2018-10.myhost.create_iscsi + TARGET=iqn.2018-10.myhost.create-iscsi atf_check -s exit:1 -e match:"Missing required argument: cfiscsi_target" ctladm port -c -d "iscsi" -O cfiscsi_portal_group_tag=$PGTAG atf_check -s exit:1 -e match:"Missing required argument: cfiscsi_portal_group_tag" ctladm port -c -d "iscsi" -O cfiscsi_target=$TARGET } @@ -288,7 +288,7 @@ remove_iscsi_body() { skip_if_ctld - TARGET=iqn.2018-10.myhost.remove_iscsi + TARGET=iqn.2018-10.myhost.remove-iscsi atf_check -o save:port-create.txt ctladm port -c -d "iscsi" -O cfiscsi_portal_group_tag=$PGTAG -O cfiscsi_target="$TARGET" portnum=`awk '/port:/ {print $2}' port-create.txt` atf_check -o save:portlist.txt ctladm portlist -qf iscsi @@ -314,7 +314,7 @@ remove_iscsi_without_required_args_body() { skip_if_ctld - TARGET=iqn.2018-10.myhost.remove_iscsi_without_required_args + TARGET=iqn.2018-10.myhost.remove-iscsi-without-required-args atf_check -o save:port-create.txt ctladm port -c -d "iscsi" -O cfiscsi_portal_group_tag=$PGTAG -O cfiscsi_target="$TARGET" echo "target: $TARGET" >> port-create.txt atf_check -s exit:1 -e match:"Missing required argument: cfiscsi_portal_group_tag" ctladm port -r -d iscsi -O cfiscsi_target="$TARGET"