From owner-freebsd-hackers@FreeBSD.ORG  Tue Jan  4 13:27:29 2011
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id D84381065672;
	Tue,  4 Jan 2011 13:27:29 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id A75CE8FC13;
	Tue,  4 Jan 2011 13:27:29 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 565F246B58;
	Tue,  4 Jan 2011 08:27:29 -0500 (EST)
Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id 876708A01D;
	Tue,  4 Jan 2011 08:27:28 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-hackers@freebsd.org
Date: Tue, 4 Jan 2011 08:05:59 -0500
User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20101102; KDE/4.4.5; amd64; ; )
References: <AANLkTimiJPiHBSw5i5TVJYfh9uGOyrNJx+oUPeB+t+Y_@mail.gmail.com>
	<xeia7heluf2q.fsf@kobe.laptop>
	<20110104112502.GM3140@deviant.kiev.zoral.com.ua>
In-Reply-To: <20110104112502.GM3140@deviant.kiev.zoral.com.ua>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201101040805.59412.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.6
	(bigwig.baldwin.cx); Tue, 04 Jan 2011 08:27:28 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.96.3 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-1.9 required=4.2 tests=BAYES_00 autolearn=ham
	version=3.3.1
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on bigwig.baldwin.cx
Cc: Kostik Belousov <kostikbel@gmail.com>, Eitan Adler <lists@eitanadler.com>,
	hackers@freebsd.org, Giorgos Keramidas <keramida@freebsd.org>
Subject: Re: [patch] have rtprio check that arguments are numeric;
	change atoi to strtol
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 04 Jan 2011 13:27:29 -0000

On Tuesday, January 04, 2011 6:25:02 am Kostik Belousov wrote:
> On Tue, Jan 04, 2011 at 11:40:45AM +0100, Giorgos Keramidas wrote:
> @@ -123,12 +121,28 @@ main(argc, argv)
>  		}
>  		exit(0);
>  	}
> -	exit (1);
> +	exit(1);
> +}
> +
> +static int
> +parseint(const char *str, const char *errname)
> +{
> +	char *endp;
> +	long res;
> +
> +	errno = 0;
> +	res = strtol(str, &endp, 10);
> +	if (errno != 0 || endp == str || *endp != '\0')
> +		err(1, "%s shall be a number", errname);

Small nit, maybe use 'must' instead of 'shall'.

-- 
John Baldwin