From owner-svn-ports-head@FreeBSD.ORG Tue Mar 12 12:49:15 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 52001AEC for ; Tue, 12 Mar 2013 12:49:15 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-wg0-f52.google.com (mail-wg0-f52.google.com [74.125.82.52]) by mx1.freebsd.org (Postfix) with ESMTP id DB20D2E9 for ; Tue, 12 Mar 2013 12:49:14 +0000 (UTC) Received: by mail-wg0-f52.google.com with SMTP id 12so6102936wgh.19 for ; Tue, 12 Mar 2013 05:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type; bh=G4WxBVRLsk/oNP0T/kEnFmwfmBOegAXzmk4qQu7bIbc=; b=fOq7P0sZgZ2LmFvXlVXE8cZeAdUElHS9r4P10D6qBLEezYH2sPiKRd2unvBBEhKHLE QtVdtQO67ZXcJklChPdg3kirDIXaDI69Ibvj/qHWpEgajh3sjFoouVpCJ7LOKfzhOxUo dzN7Mk2w/0RES0Z59LqskOSvqrv2732l5MORA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :x-gm-message-state; bh=G4WxBVRLsk/oNP0T/kEnFmwfmBOegAXzmk4qQu7bIbc=; b=WmnnzE9KOrvlwvWjl8gUOSEvsgos6Umvi03/xwbufjlC0VhzWnWACZhHj2sQUpSNdh 1pKDHqcRgHJCK1Fe182GXVAP5NQST7kWsCdh7RRtY5SeMPdSSI8aIrAxxXtbHBpVElQl cTjH5IAZGMfKMC0Ck3L0TI753jl11Blhvm4Jn/fjb2ZmSJAhz+o4TNr/HkR4A8BxKazc iEcoH7VWVKEG998seKUArUBjo4PzOXbuwGoA4u1MdOGDEv+tlprdRaFw67YAnVi4W83J n9lKH56jeDSjtqhBN8y2YJtqG3uiCZ3GfHUZWN0KpCzPUmEY9VUjfgaAZCvsDy7MQsq2 Amhw== X-Received: by 10.194.63.240 with SMTP id j16mr26319100wjs.45.1363092553613; Tue, 12 Mar 2013 05:49:13 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.194.108.106 with HTTP; Tue, 12 Mar 2013 05:48:43 -0700 (PDT) In-Reply-To: <1886726.vG9fsaSg1C@mercury.ph.man.ac.uk> References: <201303102105.r2AL5C2o048218@svn.freebsd.org> <513E5682.1070704@FreeBSD.org> <20130312014941.GC92762@FreeBSD.org> <1886726.vG9fsaSg1C@mercury.ph.man.ac.uk> From: Eitan Adler Date: Tue, 12 Mar 2013 08:48:43 -0400 X-Google-Sender-Auth: K6VEETbbLNFOUvqDCE_poiWpulc Message-ID: Subject: Re: svn commit: r313841 - head/comms/openobex To: Max Brazhnikov Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQmYd5JE8K3QJv/VXWKPh+sw+maWCoqFsh7Ym2Dywm5WSWYnCjg2FcH7ib1Ph9UDPbsq8PLB Cc: svn-ports-head@freebsd.org, Alexey Dokuchaev , Guido Falsi , svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2013 12:49:15 -0000 On 12 March 2013 07:18, Max Brazhnikov wrote: > On Tue, 12 Mar 2013 01:49:41 +0000 Alexey Dokuchaev wrote: >> On Mon, Mar 11, 2013 at 11:11:14PM +0100, Guido Falsi wrote: >> > >>Would it be feasible to make DOXYGEN default for bulk pacakge building >> > >>cases but not for regular port users (that is, hide it behind BATCH or >> > >>PACKAGE_BUILDING)? >> > >> > I do like your idea. >> > >> > I have tested the port with the following stanza after OPTIONS_DEFINE: >> > >> > .if !defined(BATCH) && !defined(PACKAGE_BUILDING) >> > OPTIONS_DEFAULT+= DOXYGEN >> > .endif >> > >> > It does work as expected, is this what you had in mind? >> >> Yes, exactly. >> >> > Should I check only against one of the two variables? Users will sometimes set BATCH to avoid interaction with the ports tree. I believe they would not expect it changes dependencies as well. PACKAGE_BUILDING seems more correct in this case. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams