From owner-freebsd-acpi@FreeBSD.ORG Thu Mar 19 13:21:00 2015 Return-Path: Delivered-To: freebsd-acpi@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id A7DA9FCE for ; Thu, 19 Mar 2015 13:21:00 +0000 (UTC) Received: from nm2-vm6.bullet.mail.ne1.yahoo.com (nm2-vm6.bullet.mail.ne1.yahoo.com [98.138.91.254]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5EFE9F23 for ; Thu, 19 Mar 2015 13:20:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=att.net; s=s1024; t=1426771085; bh=QfDU+zIpL6TN+hg1xLB5+mZCw626O0fVg2NkmdEcKdQ=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=dNwriSwjgBTvLf6TCxJaKKe+mbmFmWKMLVS5RYq3NoxDq/YEe6G7CL6hpBQcNmfw/fVmbh0TvF0Xtk57NXZVBy4s3ZS+1cxJCdQvnn8pINsMhM5VujLM3+UreVB5cfAM6wsaIdm8bV5R0iOZUcxWJAYTISinnoPBElOosUeNciY= Received: from [98.138.226.179] by nm2.bullet.mail.ne1.yahoo.com with NNFMP; 19 Mar 2015 13:18:05 -0000 Received: from [98.138.84.44] by tm14.bullet.mail.ne1.yahoo.com with NNFMP; 19 Mar 2015 13:18:05 -0000 Received: from [127.0.0.1] by smtp112.mail.ne1.yahoo.com with NNFMP; 19 Mar 2015 13:18:05 -0000 X-Yahoo-Newman-Id: 36674.25531.bm@smtp112.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: x3zjA6MVM1nT.ciUoA1G6mN5eSiIz77rUEWpHsK_AnCZxF1 4pT2d1ezQ_uWNenn8gd5fmDQbuusV2hZrrkA02n7K8ojn9iT7NPW6uG4bMw4 ZaGxiTxANWq3fFmgil7M0GAuj7a8VLnAfdfp37oOiD2zW4dzgFkiC3kTbfgR j0yJ6BX_iqh5RuQD.olvIY_0on3PpAzA4Zp3Xv4orHlO7swpWyDIpU752kQN GVpkZjopb_3UvxxJm1hsykZmdDjAyoy67h3KoybXtrZsXqWDD_z6NUA4dY_2 nZRC56Q9fxvXj4LaUYZj6iLAUUTiNjC06aPzKUfX3XJLsDRMmmsUJiNa0_oG M.ghYw2r2314Jx22RCulVSGtgbnbd.EOywT_nZaJI_REyq.ArEP6gyLkLIrr Aqr3632Jw9YMqEA.u9Dxj02DxdP.hlMVQdv.ko2BKLNgAQj1aa9.Ubc2xc2F _3hFcfwDzNICqHDGWu9x7d83Drl3Rdcny4skCKb.4SxsQ.vUhnkMJJIRCYck FGwPTgeO3K_73AF_fA31l.IX4lkKqL1XmhNlpBp6u4HM7VaNG X-Yahoo-SMTP: OKD1keCswBBTAmAF1s00hLyKW3wE3YfSK0Eazl6b4VZG4LTqJxg- Message-ID: <550ACC8B.2090201@att.net> Date: Thu, 19 Mar 2015 09:18:03 -0400 From: Anthony Jenkins User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Warner Losh Subject: Re: [PATCH] ACPI CMOS region support rev. 5 References: <20150222180817.GD27984@strugglingcoder.info> <54EB8C21.2080600@att.net> <2401337.2oUs7iAbtB@ralph.baldwin.cx> <54EF3D5D.4010106@att.net> <20150227222203.P38620@sola.nimnet.asn.au> <20150228125857.D1277@besplex.bde.org> <54F14368.4020807@att.net> <20150302002647.W42658@sola.nimnet.asn.au> <54F5E53D.1090601@att.net> <20150306025800.U46361@sola.nimnet.asn.au> <54F9D7E6.4050807@att.net> <5504FF32.3020202@att.net> <20150317001401.X22641@sola.nimnet.asn.au> <5506F00A.3030708@att.net> <5506FBE3.1000009@att.net> <20150317041624.K22641@sola.nimnet.asn.au> <55073442.5060005@att.net> <5509A0EA.4070208@att.net> <85F2CFD2-14C1-43D6-8963-0D1F69F17577@bsdimp.com> In-Reply-To: <85F2CFD2-14C1-43D6-8963-0D1F69F17577@bsdimp.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: freebsd-acpi@freebsd.org, Ian Smith X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2015 13:21:00 -0000 On 03/18/2015 05:32 PM, Warner Losh wrote: >> On Mar 18, 2015, at 9:59 AM, Anthony Jenkins wrote: >> >> On 03/18/2015 11:26 AM, Warner Losh wrote: >>> Looking at patch 5: >>> >>> You need to rework this so there’s an atrtc_acpi.c. Put all the ACPI attachment in there. >> Okay, shouldn't be a problem. >> >>> You should also split off the little bit that’s ISA-specific into atrtc_isa. >> You mean rtcin() and writertc()? ...but that's not my stuff, it was >> already in atrtc.c. PNP0800 (the PC-AT RTC component) is (practically) >> an ISA-specific device. > There will be a small “isa” specific driver. Here ISA means ‘FreeBSD ISA attachment’ not > necessarily what you’d find on an ISA bus. This means you’d have two separate driver > statement. You can then do the ACPI stuff in the ACPI attachment and not have to worry > about whether or not it is compiled into the kernel, since you’d only include it if acpi is > in the kernel. Okay I'll look for a simple example in the existing drivers...any suggestions? I was just hoping to leave atrtc(4) as intact as possible, adding an ACPI accessor for BIOSes that need it; this sounds like a reworking of atrtc(4)... Anthony > > Warner >