Date: Wed, 15 Apr 2015 18:38:06 +0300 From: Dmitry Marakasov <amdmi3@amdmi3.ru> To: marino@freebsd.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r384052 - in head/games/tomenet: . files Message-ID: <20150415153806.GA78733@hades.panopticon> In-Reply-To: <552E71F3.1030005@marino.st> References: <201504151354.t3FDshh1086098@svn.freebsd.org> <552E71F3.1030005@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
* John Marino (freebsd.contact@marino.st) wrote:
> > Log:
> > - Fix build on < 10.x
> > - Respect CC
> >
> > Approved by: portmgr blanket
> >
> > Modified:
> > head/games/tomenet/Makefile
> > head/games/tomenet/files/patch-makefile
> >
> > Modified: head/games/tomenet/Makefile
> > ==============================================================================
> > --- head/games/tomenet/Makefile Wed Apr 15 13:46:34 2015 (r384051)
> > +++ head/games/tomenet/Makefile Wed Apr 15 13:54:43 2015 (r384052)
> > @@ -31,6 +31,12 @@ OPTIONS_DEFINE= DOCS
> >
> > .include <bsd.port.options.mk>
> >
> > +.if ${OSVERSION} < 1000000
> > +LIB_DEPENDS+= libexecinfo.so:${PORTSDIR}/devel/libexecinfo
> > +CFLAGS+= -I${LOCALBASE}/include
> > +LIBS+= -L${LOCALBASE}/lib
> > +.endif
> > +
>
> 1) OSVERSION is used without OPSYS here
> 2) it matters because DragonFly needs libexecinfo
> 3) why wasn't USES+= libexec used?
Hmm, wasn't aware of USES=execinfo and completely forgot about
dragonfly. As I guess, this actually needs unconditional USES=execinfo
and conditional flags:
.if ${OPSYS} == DragonFly || ${OSVERSION} < 1000000
CFLAGS+= -I${LOCALBASE}/include
LIBS+= -L${LOCALBASE}/lib
.fi
Correct?
--
Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://amdmi3.ru
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150415153806.GA78733>