From owner-cvs-all Wed Sep 11 11:13:59 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0885037B400 for ; Wed, 11 Sep 2002 11:13:48 -0700 (PDT) Received: from mail.speakeasy.net (mail14.speakeasy.net [216.254.0.214]) by mx1.FreeBSD.org (Postfix) with ESMTP id A486943E6E for ; Wed, 11 Sep 2002 11:13:46 -0700 (PDT) (envelope-from jhb@FreeBSD.org) Received: (qmail 3726 invoked from network); 11 Sep 2002 18:14:29 -0000 Received: from unknown (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) by mail14.speakeasy.net (qmail-ldap-1.03) with DES-CBC3-SHA encrypted SMTP for ; 11 Sep 2002 18:14:29 -0000 Received: from laptop.baldwin.cx (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.5/8.12.5) with ESMTP id g8BIDiBv035811; Wed, 11 Sep 2002 14:13:44 -0400 (EDT) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.5.2 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20020911134716.A84338@espresso.q9media.com> Date: Wed, 11 Sep 2002 14:13:45 -0400 (EDT) From: John Baldwin To: Mike Barcroft Subject: Re: cvs commit: src/usr.bin/uudecode uudecode.c Cc: Kimura Fuyuki , fanf@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On 11-Sep-2002 Mike Barcroft wrote: > John Baldwin writes: >> >> On 11-Sep-2002 Mike Barcroft wrote: >> > Kimura Fuyuki writes: >> >> `n' can be minus... >> >> >> >> Index: uudecode.c >> >> =================================================================== >> >> RCS file: /home/ncvs/src/usr.bin/uudecode/uudecode.c,v >> >> retrieving revision 1.39 >> >> diff -u -r1.39 uudecode.c >> >> --- uudecode.c 11 Sep 2002 01:00:56 -0000 1.39 >> >> +++ uudecode.c 11 Sep 2002 02:59:47 -0000 >> >> @@ -153,7 +153,7 @@ >> >> decode2(void) >> >> { >> >> int base64; >> >> - size_t n; >> >> + int n; >> >> char ch, *p, *q; >> >> void *mode; >> >> struct passwd *pw; >> >> >> > >> > Unfortunately this wasn't good enough since most uses of n needed to >> > be size_t. I've added a new variable to cope. It seems to build >> > share, so hopefully world is unbroken again. Thanks for the pointer. >> > I thought I checked all the uses of n, but didn't notice the last few. >> >> Erm, ssize_t? > > That's hackish to cram two unrelated temporary variables into one. It > wouldn't be bad if they both needed to be the same type, but in this > case there are really two separate needs for two separate types. > Also, using ssize_t would require at least one additional cast to > avoid a signed unsigned comparison. Ah, didn't realize it was being overloaded for two different things. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message