From owner-trustedbsd-cvs@FreeBSD.ORG  Mon Dec  4 16:44:59 2006
Return-Path: <owner-trustedbsd-cvs@FreeBSD.ORG>
X-Original-To: trustedbsd-cvs@freebsd.org
Delivered-To: trustedbsd-cvs@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id BA70716A501
	for <trustedbsd-cvs@freebsd.org>; Mon,  4 Dec 2006 16:44:59 +0000 (UTC)
	(envelope-from owner-perforce@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [209.31.154.42])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E691543CCC
	for <trustedbsd-cvs@freebsd.org>; Mon,  4 Dec 2006 16:39:26 +0000 (GMT)
	(envelope-from owner-perforce@freebsd.org)
Received: from mx2.freebsd.org (mx2.freebsd.org [69.147.83.53])
	by cyrus.watson.org (Postfix) with ESMTP id 48E6E46F0E
	for <trustedbsd-cvs@trustedbsd.org>;
	Mon,  4 Dec 2006 11:39:59 -0500 (EST)
Received: from hub.freebsd.org (hub.freebsd.org [69.147.83.54])
	by mx2.freebsd.org (Postfix) with ESMTP id 8186156992;
	Mon,  4 Dec 2006 16:39:52 +0000 (GMT)
	(envelope-from owner-perforce@freebsd.org)
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id EE0B416A4FF; Mon,  4 Dec 2006 16:39:57 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C919616A4CE
	for <perforce@freebsd.org>; Mon,  4 Dec 2006 16:39:57 +0000 (UTC)
	(envelope-from millert@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.FreeBSD.org (Postfix) with ESMTP id E6CAE44008
	for <perforce@freebsd.org>; Mon,  4 Dec 2006 16:34:21 +0000 (GMT)
	(envelope-from millert@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id kB4GXVoK058487
	for <perforce@freebsd.org>; Mon, 4 Dec 2006 16:33:31 GMT
	(envelope-from millert@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id kB4GXU3s058484
	for perforce@freebsd.org; Mon, 4 Dec 2006 16:33:30 GMT
	(envelope-from millert@freebsd.org)
Date: Mon, 4 Dec 2006 16:33:30 GMT
Message-Id: <200612041633.kB4GXU3s058484@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	millert@freebsd.org using -f
From: Todd Miller <millert@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 111015 for review
X-BeenThere: trustedbsd-cvs@FreeBSD.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: TrustedBSD CVS and Perforce commit message list
	<trustedbsd-cvs.FreeBSD.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/trustedbsd-cvs>, 
	<mailto:trustedbsd-cvs-request@FreeBSD.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/trustedbsd-cvs>
List-Post: <mailto:trustedbsd-cvs@FreeBSD.org>
List-Help: <mailto:trustedbsd-cvs-request@FreeBSD.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/trustedbsd-cvs>,
	<mailto:trustedbsd-cvs-request@FreeBSD.org?subject=subscribe>
X-List-Received-Date: Mon, 04 Dec 2006 16:45:00 -0000

http://perforce.freebsd.org/chv.cgi?CH=111015

Change 111015 by millert@millert_g5tower on 2006/12/04 16:32:52

	Add missing check for read-only filesystem in mac_vnop_setxattr()
	and mac_vnop_removexattr().

Affected files ...

.. //depot/projects/trustedbsd/sedarwin8/darwin/xnu/security/mac_vfs_subr.c#8 edit

Differences ...

==== //depot/projects/trustedbsd/sedarwin8/darwin/xnu/security/mac_vfs_subr.c#8 (text+ko) ====

@@ -156,6 +156,9 @@
         uio_t auio;
 	int error;
 
+	if (vfs_isrdonly(vp->v_mount))
+		return (EROFS);
+
 	context.vc_proc = current_proc();
 	context.vc_ucred = kauth_cred_get();
 	auio = uio_createwithbuffer(1, 0, UIO_SYSSPACE, UIO_WRITE,
@@ -198,6 +201,9 @@
 	struct vfs_context context;
 	int error;
 
+	if (vfs_isrdonly(vp->v_mount))
+		return (EROFS);
+
 	context.vc_proc = current_proc();
 	context.vc_ucred = kauth_cred_get();