From owner-freebsd-bugs@freebsd.org Mon Mar 9 01:52:01 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 38573254127 for ; Mon, 9 Mar 2020 01:52:01 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 48bLnD68cSz3xXD for ; Mon, 9 Mar 2020 01:52:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id B3E36254126; Mon, 9 Mar 2020 01:52:00 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B355B254125 for ; Mon, 9 Mar 2020 01:52:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48bLnD31pDz3xWS for ; Mon, 9 Mar 2020 01:52:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 516063706 for ; Mon, 9 Mar 2020 01:52:00 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 0291q0SY008172 for ; Mon, 9 Mar 2020 01:52:00 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 0291q0L5008171 for bugs@FreeBSD.org; Mon, 9 Mar 2020 01:52:00 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 244686] fusefs: fuse ops header's unique values aren't always unique Date: Mon, 09 Mar 2020 01:52:00 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: asomers@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Mar 2020 01:52:01 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D244686 Bug ID: 244686 Summary: fusefs: fuse ops header's unique values aren't always unique Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: asomers@FreeBSD.org Every FUSE operation has a unique value in its header. As the name implies, these values are supposed to be unique among all outstanding operations. A= nd sine FUSE_INTERRUPT is asynchronous and racy, it is desirable that the uniq= ue values be unique among all operations that are "close in time". But in our module, they aren't always unique. We inadvertently reuse them during fsyn= c, readdir, LISTXATTR, and WRITE. The problem can be easily demonstrated like this: cd /usr/tests/sys/fs/fusefs > ./xattr --gtest_filter=3DListxattr.user -vv Note: Google Test filter =3D Listxattr.user [=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from Listxattr [ RUN ] Listxattr.user ACCESS ino=3D 1 uid=3D 1000 gid=3D 1000 pid=3D 848 unique=3D2 len=3D4= 8 buflen=3D48 mask=3D0x1 LOOKUP ino=3D 1 uid=3D 1000 gid=3D 1000 pid=3D 848 unique=3D3 len=3D5= 4 buflen=3D54 some_file.txt LISTXATTR ino=3D42 uid=3D 1000 gid=3D 1000 pid=3D 848 unique=3D4 len=3D4= 8 buflen=3D48 size=3D0 LISTXATTR ino=3D42 uid=3D 1000 gid=3D 1000 pid=3D 848 unique=3D4 len=3D4= 8 buflen=3D48 size=3D28 [ OK ] Listxattr.user (3 ms) [----------] 1 test from Listxattr (3 ms total) [----------] Global test environment tear-down [=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D] 1 test from 1 test case ran. (3 ms total) [ PASSED ] 1 test. We should ensure that the value is regenerated during fdisp_refresh_vp(). --=20 You are receiving this mail because: You are the assignee for the bug.=