Date: Wed, 7 Jan 2015 09:44:31 -0800 From: John-Mark Gurney <jmg@funkthat.com> To: Robert Watson <rwatson@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r276750 - in head: share/man/man9 sys/contrib/ipfilter/netinet sys/dev/an sys/dev/bge sys/dev/ce sys/dev/cm sys/dev/cp sys/dev/cs sys/dev/ctau sys/dev/ed sys/dev/ex sys/dev/fe sys/dev/h... Message-ID: <20150107174430.GQ1949@funkthat.com> In-Reply-To: <201501061259.t06CxcTc096488@svn.freebsd.org> References: <201501061259.t06CxcTc096488@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Robert Watson wrote this message on Tue, Jan 06, 2015 at 12:59 +0000: > Author: rwatson > Date: Tue Jan 6 12:59:37 2015 > New Revision: 276750 > URL: https://svnweb.freebsd.org/changeset/base/276750 > > Log: > In order to reduce use of M_EXT outside of the mbuf allocator and > socket-buffer implementations, introduce a return value for MCLGET() > (and m_cljget() that underlies it) to allow the caller to avoid testing > M_EXT itself. Update all callers to use the return value. > > With this change, very few network device drivers remain aware of > M_EXT; the primary exceptions lie in mbuf-chain pretty printers for > debugging, and in a few cases, custom mbuf and cluster allocation > implementations. > > NB: This is a difficult-to-test change as it touches many drivers for > which I don't have physical devices. Instead we've gone for intensive > review, but further post-commit review would definitely be appreciated > to spot errors where changes could not easily be made mechanically, > but were largely mechanical in nature. Shouldn't this come w/ a FreeBSD version bump for drivers to use? -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150107174430.GQ1949>