From owner-freebsd-commit  Wed Apr  5 23:39:13 1995
Return-Path: commit-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id XAA11927
          for commit-outgoing; Wed, 5 Apr 1995 23:39:13 -0700
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id XAA11914
          for cvs-ports-outgoing; Wed, 5 Apr 1995 23:39:07 -0700
Received: from time.cdrom.com (time.cdrom.com [192.216.223.46])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id XAA11908
          ; Wed, 5 Apr 1995 23:39:04 -0700
Received: from estienne.cs.berkeley.edu (estienne.CS.Berkeley.EDU [128.32.42.147]) by time.cdrom.com (8.6.11/8.6.9) with ESMTP id XAA10257; Wed, 5 Apr 1995 23:39:03 -0700
Received: from localhost (localhost [127.0.0.1]) by estienne.cs.berkeley.edu (8.6.11/8.6.9) with SMTP id XAA21740; Wed, 5 Apr 1995 23:38:53 -0700
Message-Id: <199504060638.XAA21740@estienne.cs.berkeley.edu>
X-Authentication-Warning: estienne.cs.berkeley.edu: Host localhost didn't use HELO protocol
To: "Jordan K. Hubbard" <jkh@freefall.cdrom.com>
cc: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>,
        jkh@freebsd.org (Jordan K. Hubbard), CVS-commiters@time.cdrom.com,
        cvs-ports@time.cdrom.com, vode@snakemail.hut.fi
Subject: Re: cvs commit: ports/net/sup/patches patch-ae 
In-reply-to: Your message of "Wed, 05 Apr 1995 23:19:13 PDT."
             <11471.797149153@freefall.cdrom.com> 
Date: Wed, 05 Apr 1995 23:38:52 -0700
From: "Justin T. Gibbs" <gibbs@estienne.cs.berkeley.edu>
Sender: commit-owner@freebsd.org
Precedence: bulk

>> No man page updates for it :-(.
>> No way to turn it off :-(.
>> 
>> And admitted hackery in the code:
>> +       char rfname[1024];      /* Kludge alert.. */
>
>
>1. Sorry, I thought he'd changed the manpage.  I'll document it if he
>   doesn't beat me to it.
>
>2. You turn it off by not creating a file with the special name.. :-)

It doubles the number of stats needed to do an upgrade.  It needs to
be implemented another way and an option.  I should be able to create
#sup files all I want if I choose to distribute them via SUP.

>
>3. You would prefer that he simply not admit to the hackery? ;-)

No, he should have used PATH_MAX or SUP's own STRINGLENGTH there I 
would guess.

This patch, to a program that is crucial to so many developers, was
adopted too quickly.  The author even admitted to only a nights worth
of testing.

>
>						Jordan

--
Justin T. Gibbs
==============================================
TCS Instructional Group - Programmer/Analyst 1
  Cory | Po | Danube | Volga | Parker | Torus
==============================================