From owner-cvs-all Fri Jun 7 1: 0:45 2002 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id DD67A37B42C; Fri, 7 Jun 2002 01:00:21 -0700 (PDT) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.3/8.12.3) with ESMTP id g5780AaR097711; Fri, 7 Jun 2002 12:00:16 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.3/8.12.3/Submit) id g57808sU097709; Fri, 7 Jun 2002 12:00:08 +0400 (MSD) Date: Fri, 7 Jun 2002 12:00:06 +0400 From: "Andrey A. Chernov" To: "Tim J. Robbins" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/uniq uniq.c Message-ID: <20020607080005.GA97574@nagual.pp.ru> References: <200206061344.g56DiEX47747@freefall.freebsd.org> <20020607101552.A46543@treetop.robbins.dropbear.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20020607101552.A46543@treetop.robbins.dropbear.id.au> User-Agent: Mutt/1.3.28i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Fri, Jun 07, 2002 at 10:15:52 +1000, Tim J. Robbins wrote: > Please make the behaviour of "sort -u" consistent with "sort | uniq", then, > if both are to use LC_COLLATE. The sort utility from (at least) textutils > 2.0.21 uses strcoll() == 0 as a check for uniqueness (as Solaris does in its > sort utility) and has workarounds to handle embedded NUL bytes etc. It seems we need to upgrade our sort to that variant. I'll try to look at it closer. What we currently have in sort.c in some cases do character-by-character comparison which is not compatible with "substitute". > I am not sure if any earlier versions of textutils handled locale collation > order (the code looks to be <5 months old). It's on alpha.gnu.org. Old GNU sort.c do nothing about collation or decimal point. See my changes to current sort.c, ifdefed with FreeBSD. New GNU sort does largely the same things I do many years ago. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message