From owner-p4-projects@FreeBSD.ORG Mon Sep 17 08:50:19 2007 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 3308D16A468; Mon, 17 Sep 2007 08:50:19 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EFC6F16A418 for ; Mon, 17 Sep 2007 08:50:18 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.190]) by mx1.freebsd.org (Postfix) with ESMTP id 77A2313C46B for ; Mon, 17 Sep 2007 08:50:18 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so1072185nfb for ; Mon, 17 Sep 2007 01:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; bh=tCMu08DIMZpJugExdn4TYC2Fhu2dcZpQR+YkXpf1W6c=; b=TQ3Tel343tZUgmiR8twYoXQNJBY0dXp1zMT3OPOXCCqQZAkGTCts4prpcteqDjDhIrGO61nXpozxoKHrOwjOxicmNqX56Y0W08E+M7sXsujGyk6u4NmxMRIVctLnyjHq4OWmvZgKjQtuQLSxDk58RTTYhlP2ShixJDITgejR4Iw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=oIkJgC4CxWeLOAOaMRO48RzexVHTEmIXBCDvSP2q/k6X8cqNI0zqy1jGh0LfvY3LuZLrmBbXypmtR+xXoxngzZW63arcGEmV33F7u57OTwpHhAeyl0GP+K6jUmz3297Al938Yqq+eiy9/j7TVW6T461+e32HAj38TaWjKd7j/iw= Received: by 10.78.159.7 with SMTP id h7mr2444933hue.1190019016937; Mon, 17 Sep 2007 01:50:16 -0700 (PDT) Received: by 10.78.162.18 with HTTP; Mon, 17 Sep 2007 01:50:16 -0700 (PDT) Message-ID: Date: Mon, 17 Sep 2007 01:50:16 -0700 From: "Kip Macy" To: "Andre Oppermann" In-Reply-To: <46EE30A8.7020809@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200709162157.l8GLvpx2080125@repoman.freebsd.org> <46EE30A8.7020809@freebsd.org> Cc: Perforce Change Reviews , Kip Macy Subject: Re: PERFORCE change 126488 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Sep 2007 08:50:19 -0000 On 9/17/07, Andre Oppermann wrote: > Kip Macy wrote: > > http://perforce.freebsd.org/chv.cgi?CH=126488 > > > > Change 126488 by kmacy@kmacy_home:ethng on 2007/09/16 21:57:27 > > > > add a route structure to the inpcb > > release the reference to the rt_entry if its set when we free the inpcb > > We already had this once before and it was nasty as you had to > do a full inpcb walk to nuke any references if a route changed. Nope. If you keep a generation counter for the route in the inpcb and check it each time in udp_output against the rtentry / route table you'll know that your cached route is no longer valid. I'm not currently doing that, but it won't be hard to add. In any event, incurring a 20% slowdown (in the uncontended case, its basically crippling in the contended case i.e. 1 flow on the same route) for an event that occurs < .01% of the time on most networks seems questionable. -Kip