Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 Apr 2016 05:22:36 +0000 (UTC)
From:      Sepherosa Ziehau <sephe@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r298569 - head/sys/dev/hyperv/vmbus
Message-ID:  <201604250522.u3P5MaXY011667@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: sephe
Date: Mon Apr 25 05:22:35 2016
New Revision: 298569
URL: https://svnweb.freebsd.org/changeset/base/298569

Log:
  hyperv/channel: Remove the unnecessary 'new' flag
  
  MFC after:	1 week
  Sponsored by:	Microsoft OSTC

Modified:
  head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c

Modified: head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c
==============================================================================
--- head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c	Mon Apr 25 04:58:14 2016	(r298568)
+++ head/sys/dev/hyperv/vmbus/hv_channel_mgmt.c	Mon Apr 25 05:22:35 2016	(r298569)
@@ -174,13 +174,10 @@ hv_vmbus_free_vmbus_channel(hv_vmbus_cha
 static void
 vmbus_channel_process_offer(hv_vmbus_channel *new_channel)
 {
-	boolean_t		f_new;
 	hv_vmbus_channel*	channel;
 	int			ret;
 	uint32_t                relid;
 
-	f_new = TRUE;
-	channel = NULL;
 	relid = new_channel->offer_msg.child_rel_id;
 	/*
 	 * Make sure this is a new offer
@@ -196,14 +193,12 @@ vmbus_channel_process_offer(hv_vmbus_cha
 		    sizeof(hv_guid)) == 0 &&
 		    memcmp(&channel->offer_msg.offer.interface_instance,
 		    &new_channel->offer_msg.offer.interface_instance,
-		    sizeof(hv_guid)) == 0) {
-			f_new = FALSE;
+		    sizeof(hv_guid)) == 0)
 			break;
-		}
 	}
 
-	if (f_new) {
-		/* Insert at tail */
+	if (channel == NULL) {
+		/* Install the new primary channel */
 		TAILQ_INSERT_TAIL(
 		    &hv_vmbus_g_connection.channel_anchor,
 		    new_channel,
@@ -213,7 +208,7 @@ vmbus_channel_process_offer(hv_vmbus_cha
 
 	/*XXX add new channel to percpu_list */
 
-	if (!f_new) {
+	if (channel != NULL) {
 		/*
 		 * Check if this is a sub channel.
 		 */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201604250522.u3P5MaXY011667>